Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up a post-commit bot to test workspace builds #155

Merged
merged 0 commits into from Feb 17, 2022
Merged

Set up a post-commit bot to test workspace builds #155

merged 0 commits into from Feb 17, 2022

Conversation

ryanhaddad
Copy link
Contributor

@ryanhaddad ryanhaddad commented Feb 16, 2022 •
edited

168bc34

Set up a post-commit bot to test workspace builds
https://bugs.webkit.org/show_bug.cgi?id=236726

Reviewed by Jonathan Bedard.

* CISupport/build-webkit-org/config.json:
* CISupport/build-webkit-org/factories_unittest.py:
(TestExpectedBuildSteps):


Canonical link: https://commits.webkit.org/247365@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@ryanhaddad ryanhaddad self-assigned this Feb 16, 2022
@ryanhaddad
Copy link
Contributor Author

  • @emw-apple in case you have comments about the naming of this queue.

emw-apple
emw-apple requested changes Feb 16, 2022
View reviewed changes
Tools/CISupport/build-webkit-org/factories_unittest.py
'clean-and-update-working-directory',
'show-identifier',
'kill-old-processes',
'delete-WebKitBuild-directory',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we persist WebKitBuild between builds, like EWS does? One thing I'd like this bot to be testing is whether incremental builds are successful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though impossible to determine from this unit test, the 'delete-WebKitBuild-directory' step would only run if someone triggered a clean build.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, nevermind then :)

JonWBedard
JonWBedard requested changes Feb 16, 2022
View reviewed changes
Tools/CISupport/build-webkit-org/config.json Outdated
@@ -292,6 +292,11 @@
"platform": "mac-bigsur", "configuration": "release", "architectures": ["x86_64", "arm64"],
"workernames": ["bot184"]
},
{ "name": "Apple-BigSur-XCBuild-Release-Build", "factory": "BuildFactory", "builddir": "bigsur-release",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like EWS caught a bug for you:

Configuration Errors:
  duplicate builder builddir 'bigsur-release'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I have to wonder why python3 runUnittests.py build-webkit-org told me all tests passed!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was buildbot checkconfig that actually flagged the failure, looking at the logs.

@ryanhaddad ryanhaddad force-pushed the eng/236726-workspace-build-queue branch from 7680acd to bde66c3 Compare February 16, 2022 23:00
emw-apple
emw-apple approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@emw-apple emw-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming and build arguments LGTM!

@ryanhaddad
Copy link
Contributor Author

Testing here before landing: https://build.webkit-dev.org/#/builders/123/builds/1

@ryanhaddad ryanhaddad closed this Feb 17, 2022
@ryanhaddad ryanhaddad force-pushed the eng/236726-workspace-build-queue branch from bde66c3 to 168bc34 Compare February 17, 2022 00:03
@ryanhaddad ryanhaddad merged commit 168bc34 into WebKit:main Feb 17, 2022
@ryanhaddad
Copy link
Contributor Author

Landed https://commits.webkit.org/247365@main (168bc34)!

@ryanhaddad ryanhaddad deleted the eng/236726-workspace-build-queue branch February 17, 2022 00:04
@JonWBedard JonWBedard added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonWBedard JonWBedard JonWBedard approved these changes

@emw-apple emw-apple emw-apple approved these changes

@aj062 aj062 Awaiting requested review from aj062

Assignees

@ryanhaddad ryanhaddad

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
3 participants
@ryanhaddad @JonWBedard @emw-apple