Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make <attachment> progress circle use a single element #15532

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Make <attachment> progress circle use a single element #15532

merged 1 commit into from
Jul 4, 2023

Conversation

nt1m
Copy link
Member

@nt1m nt1m commented Jul 4, 2023 •
edited by webkit-early-warning-system
Loading

e8d22b5

Make <attachment> progress circle use a single element
https://bugs.webkit.org/show_bug.cgi?id=258840
rdar://111719618

Reviewed by Antti Koivisto.

Use a pseudo-element (::before) to avoid needing to create a separate element in the DOM.

* LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt:
* LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt:
* Source/WebCore/html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::ensureWideLayoutShadowTree):
(WebCore::attachmentProgressCircleIdentifier): Deleted.
* Source/WebCore/html/shadow/attachmentElementShadow.css:
(div#attachment-progress::before):
(div#attachment-progress-circle): Deleted.

Canonical link: https://commits.webkit.org/265749@main

8d5ed72

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@nt1m nt1m requested review from cdumez and rniwa as code owners July 4, 2023 05:03
@nt1m nt1m self-assigned this Jul 4, 2023
@nt1m nt1m added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Jul 4, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 4, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 2786ef4)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ⏳ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk2 ✅ 🧪 api-gtk
⏳ 🛠 🧪 jsc-arm64 ✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m requested review from whsieh, pxlcoder and heycam July 4, 2023 05:04
@nt1m nt1m added the request-merge-queue Request a pull request to be added to merge-queue once ready label Jul 4, 2023
@webkit-ews-buildbot webkit-ews-buildbot added merging-blocked Applied to prevent a change from being merged and removed request-merge-queue Request a pull request to be added to merge-queue once ready labels Jul 4, 2023
@nt1m nt1m removed the merging-blocked Applied to prevent a change from being merged label Jul 4, 2023
@nt1m nt1m force-pushed the eng/Make-attachment-progress-circle-use-a-single-element branch from 2786ef4 to ff76dab Compare July 4, 2023 06:30
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 4, 2023 •
edited
Loading

EWS run on previous version of this PR (hash ff76dab)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ⏳ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc ✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🧪 api-gtk
⏳ 🛠 🧪 jsc-arm64 ✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
❌ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m added the merge-queue Applied to send a pull request to merge-queue label Jul 4, 2023
@webkit-ews-buildbot webkit-ews-buildbot added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Jul 4, 2023
@nt1m nt1m removed the merging-blocked Applied to prevent a change from being merged label Jul 4, 2023
@nt1m nt1m force-pushed the eng/Make-attachment-progress-circle-use-a-single-element branch from ff76dab to 8d5ed72 Compare July 4, 2023 09:11
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 4, 2023 •
edited
Loading

EWS run on current version of this PR (hash 8d5ed72)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@nt1m nt1m added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 4, 2023
@nt1m
Make <attachment> progress circle use a single element
e8d22b5 
https://bugs.webkit.org/show_bug.cgi?id=258840
rdar://111719618

Reviewed by Antti Koivisto.

Use a pseudo-element (::before) to avoid needing to create a separate element in the DOM.

* LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt:
* LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt:
* Source/WebCore/html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::ensureWideLayoutShadowTree):
(WebCore::attachmentProgressCircleIdentifier): Deleted.
* Source/WebCore/html/shadow/attachmentElementShadow.css:
(div#attachment-progress::before):
(div#attachment-progress-circle): Deleted.

Canonical link: https://commits.webkit.org/265749@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Make-attachment-progress-circle-use-a-single-element branch from 8d5ed72 to e8d22b5 Compare July 4, 2023 09:15
@webkit-commit-queue
Copy link
Collaborator

Committed 265749@main (e8d22b5): https://commits.webkit.org/265749@main

Reviewed commits have been landed. Closing PR #15532 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit e8d22b5 into WebKit:main Jul 4, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 4, 2023
@nt1m nt1m deleted the eng/Make-attachment-progress-circle-use-a-single-element branch November 3, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anttijk anttijk anttijk approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@rniwa rniwa Awaiting requested review from rniwa rniwa is a code owner

@whsieh whsieh Awaiting requested review from whsieh

@pxlcoder pxlcoder Awaiting requested review from pxlcoder

@heycam heycam Awaiting requested review from heycam

Assignees

@nt1m nt1m

Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
Milestone
No milestone
5 participants
@nt1m @webkit-early-warning-system @webkit-commit-queue @anttijk @webkit-ews-buildbot