-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not convert testharness paths in import-w3c-tests #15547
Do not convert testharness paths in import-w3c-tests #15547
Conversation
EWS run on current version of this PR (hash cc990ee) |
(note this is just @csnardi's patch from 2018, from the linked bug, rebased) |
Conversion of links may still happen for LayoutTests/imported/blink.
Can you acknowledge this in the commit message? |
Did
Is the commit author not enough? |
https://bugs.webkit.org/show_bug.cgi?id=185876 Reviewed by Jonathan Bedard. Since the csswg-tests repo was merged into WPT, there is only one test repository now in imported/w3c/resources/TestRepositories, which does not specify the option to convert testharness paths from relative paths to explicit paths. Additionally, wptserve has been used for some time, so run-webkit-tests should have no problem with relative paths to the testharness paths. Thus, there is no reason to continue converting testharness paths, so this patch removes all code related to that conversion. * Scripts/webkitpy/w3c/test_converter.py: (convert_for_webkit): (_W3CTestConverter.__init__): (_W3CTestConverter.convert_attributes_if_needed): * Scripts/webkitpy/w3c/test_converter_unittest.py: (verify_test_harness_paths): * Scripts/webkitpy/w3c/test_importer.py: (TestImporter.find_importable_tests): (TestImporter.import_tests): Canonical link: https://commits.webkit.org/265842@main
cc990ee
to
1866a4e
Compare
Committed 265842@main (1866a4e): https://commits.webkit.org/265842@main Reviewed commits have been landed. Closing PR #15547 and removing active labels. |
1866a4e
cc990ee