Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting outerHTML on child of DocumentFragment should not throw error #15575

Commits on Jul 15, 2023

  1. Setting outerHTML on child of DocumentFragment should not throw error

    https://bugs.webkit.org/show_bug.cgi?id=249737
    rdar://problem/103746193
    
    Reviewed by Chris Dumez.
    
    This patch aligns WebKit with Gecko / Firefox and Web-Spec [1].
    
    In 238774@main, WebKit aligned with behavior for better compatibility but
    it was not correct and clarified later to not throw error [2]. This PR is
    essentially revert part of 238774@main with update to align by not throwing error.
    
    [1] https://w3c.github.io/DOM-Parsing/#dom-element-outerhtml
    [2] whatwg/html#8657
    
    * Source/WebCore/dom/Element.cpp:
    (Element::setOuterHTML): Update to not throw error
    * LayoutTests/fast/dynamic/outerHTML-no-element.html: Rebaselined
    * LayoutTests/fast/dynamic/outerHTML-no-element-expected.txt: Rebaselined
    * LayoutTests/fast/dom/set-outer-html-special-cases.html: Rebaselined
    * LayoutTests/fast/dom/set-outer-html-special-cases-expected.txt: Rebaselined
    
    Canonical link: https://commits.webkit.org/266086@main
    Ahmad-S792 authored and cdumez committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    b41af45 View commit details
    Browse the repository at this point in the history