Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GStreamer] Support serializing caps list fields to JSON #15596

Merged
merged 1 commit into from
Jul 6, 2023
Merged

[GStreamer] Support serializing caps list fields to JSON #15596

merged 1 commit into from
Jul 6, 2023

Conversation

philn
Copy link
Member

@philn philn commented Jul 6, 2023 •
edited by webkit-early-warning-system
Loading

1e8400a

[GStreamer] Support serializing caps list fields to JSON
https://bugs.webkit.org/show_bug.cgi?id=258921

Reviewed by Xabier Rodriguez-Calvar.

Serialize GStreamer structure list fields to JSON arrays.

* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::gstStructureValueToJSON):
* Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp:
(TestWebKitAPI::TEST_F):

Canonical link: https://commits.webkit.org/265809@main

59c3a1a

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@philn philn self-assigned this Jul 6, 2023
@philn philn added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Jul 6, 2023
@philn philn requested a review from calvaris July 6, 2023 12:04
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 6, 2023 •
edited
Loading

EWS run on current version of this PR (hash 59c3a1a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@philn philn added the merge-queue Applied to send a pull request to merge-queue label Jul 6, 2023
@philn
[GStreamer] Support serializing caps list fields to JSON
1e8400a 
https://bugs.webkit.org/show_bug.cgi?id=258921

Reviewed by Xabier Rodriguez-Calvar.

Serialize GStreamer structure list fields to JSON arrays.

* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::gstStructureValueToJSON):
* Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp:
(TestWebKitAPI::TEST_F):

Canonical link: https://commits.webkit.org/265809@main
@webkit-commit-queue
Copy link
Collaborator

Committed 265809@main (1e8400a): https://commits.webkit.org/265809@main

Reviewed commits have been landed. Closing PR #15596 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 1e8400a into WebKit:main Jul 6, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 6, 2023
@philn philn deleted the eng/258921 branch July 6, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvaris calvaris calvaris approved these changes

Assignees

@philn philn

Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
Milestone
No milestone
4 participants
@philn @webkit-early-warning-system @webkit-commit-queue @calvaris