Transparent, composited canvas is rendered black when layer is changed to render layer backing sharing #15599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash a34982c)
|
kkinnunen-apple
requested review from
smfr
and removed request for
rniwa and
cdumez
smfr
approved these changes
Jul 6, 2023
| @@ -3443,6 +3443,9 @@ void RenderLayerBacking::paintIntoLayer(const GraphicsLayer* graphicsLayer, Grap | |||
| #endif | |||
| return; | |||
| } | |||
| GraphicsContextStateSaver saver(context, m_shouldPaintUsingCompositeCopy); | |||
| if (m_shouldPaintUsingCompositeCopy) | |||
| context.setCompositeOperation(CompositeOperator::Copy); | |||
There was a problem hiding this comment.
It feels a bit weird to do this here. Sure, we know that the canvas is the only thing painted into this layer, but it looks weird to have this cover the scope of all the painting. Maybe it will do something odd for event regions, for example.
There was a problem hiding this comment.
I'd feel OK if this was moved to before layer.paintLayerContents().
kkinnunen-apple
force-pushed
the
canvas-composite-copy-remotelayerbacking-changes-1
branch
from
a34982c
to
e43669b
Compare
|
EWS run on current version of this PR (hash e43669b)
|
kkinnunen-apple
added
the
merge-queue
…d to render layer backing sharing https://bugs.webkit.org/show_bug.cgi?id=258927 rdar://110088034 Reviewed by Simon Fraser. Explicitly composited canvas element might switch to being composited to other RenderLayerBacking. This left the RenderLayer::m_shouldPaintUsingCompositeCopy unreset. Instead, store the flag to RenderLayerBacking. * Source/WebCore/html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint): * Source/WebCore/html/HTMLCanvasElement.h: * Source/WebCore/rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced): * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): * Source/WebCore/rendering/RenderLayer.h: (WebCore::RenderLayer::shouldPaintUsingCompositeCopy const): Deleted. (WebCore::RenderLayer::setShouldPaintUsingCompositeCopy): Deleted. * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateConfiguration): (WebCore::RenderLayerBacking::paintIntoLayer): * Source/WebCore/rendering/RenderLayerBacking.h: Canonical link: https://commits.webkit.org/265837@main
webkit-commit-queue
force-pushed
the
canvas-composite-copy-remotelayerbacking-changes-1
branch
from
e43669b
to
dbef4cf
Compare
|
Committed 265837@main (dbef4cf): https://commits.webkit.org/265837@main Reviewed commits have been landed. Closing PR #15599 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbef4cf
e43669b