Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LibWPE] Fix click count logic #15651

Merged

Conversation

donny-dont
Copy link
Contributor

@donny-dont donny-dont commented Jul 7, 2023

4776b34

[LibWPE] Fix click count logic
https://bugs.webkit.org/show_bug.cgi?id=259000

Reviewed by Michael Catanzaro.

When comparing screen coordinates for a click `==` was used instead of
a subtraction. Also modify the threshold to be an int so there isn't
a type warning since `std::abs` outputs an `int` not an `unsigned`.

* Source/WebKit/Shared/libwpe/WebEventFactory.cpp:
(WebKit::clickCount):

Canonical link: https://commits.webkit.org/265874@main

d531ec4

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 ❌ πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@donny-dont donny-dont self-assigned this Jul 7, 2023
@donny-dont donny-dont added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Jul 7, 2023
@donny-dont donny-dont requested a review from dpino July 7, 2023 22:44
@donny-dont donny-dont marked this pull request as ready for review July 7, 2023 22:55
@donny-dont donny-dont requested review from a team and zdobersek as code owners July 7, 2023 22:55
@donny-dont donny-dont added the merge-queue Applied to send a pull request to merge-queue label Jul 8, 2023
https://bugs.webkit.org/show_bug.cgi?id=259000

Reviewed by Michael Catanzaro.

When comparing screen coordinates for a click `==` was used instead of
a subtraction. Also modify the threshold to be an int so there isn't
a type warning since `std::abs` outputs an `int` not an `unsigned`.

* Source/WebKit/Shared/libwpe/WebEventFactory.cpp:
(WebKit::clickCount):

Canonical link: https://commits.webkit.org/265874@main
@webkit-commit-queue
Copy link
Collaborator

Committed 265874@main (4776b34): https://commits.webkit.org/265874@main

Reviewed commits have been landed. Closing PR #15651 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 4776b34 into WebKit:main Jul 8, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
4 participants