Wide-layout attachments: Fix baseline computation #15680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squelart
added
the
HTML Editing
|
EWS run on previous version of this PR (hash 389da92)
|
webkit-ews-buildbot
added
the
merging-blocked
squelart
removed
the
merging-blocked
squelart
force-pushed
the
eng/fixed-wide-layout-attachment-baseline
branch
from
389da92
to
978f0ff
Compare
|
EWS run on previous version of this PR (hash 978f0ff)
|
nt1m
approved these changes
Jul 10, 2023
squelart
force-pushed
the
eng/fixed-wide-layout-attachment-baseline
branch
from
978f0ff
to
ab36b2f
Compare
|
EWS run on current version of this PR (hash ab36b2f)
|
https://bugs.webkit.org/show_bug.cgi?id=259039 rdar://problem/111991128 Reviewed by Tim Nguyen. The previous computation used `renderRect`s, which relied on the baseline, modifying the baseline again and again. Instead, assume that the image is vertically centred, so it's just a matter of adding half-heights to find the bottom of that image. (Fallback to the full attachment height alone in case the inner element doesn't have its height yet.) * LayoutTests/fast/attachment/mac/wide-attachment-image-controls-basic-expected.txt: * LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt: * LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt: * Source/WebCore/rendering/RenderAttachment.cpp: (WebCore::RenderAttachment::baselinePosition const): Canonical link: https://commits.webkit.org/265894@main
webkit-commit-queue
force-pushed
the
eng/fixed-wide-layout-attachment-baseline
branch
from
ab36b2f
to
28021b9
Compare
|
Committed 265894@main (28021b9): https://commits.webkit.org/265894@main Reviewed commits have been landed. Closing PR #15680 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Comment on lines
+103
to
+105
| if (auto* baselineElementRenderBox = baselineElement->renderBox()) { | ||
| // This is the bottom of the image assuming it is vertically centered. | ||
| return (height() + baselineElementRenderBox->height()) / 2; |
There was a problem hiding this comment.
does wide-attachment support vertical writing mode in general?
There was a problem hiding this comment.
Not at this time, no.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
28021b9
ab36b2f