Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dormant queues from bot watchers dashboard #157

Merged
merged 0 commits into from Feb 22, 2022
Merged

Remove dormant queues from bot watchers dashboard #157

merged 0 commits into from Feb 22, 2022

Conversation

ryanhaddad
Copy link
Contributor

@ryanhaddad ryanhaddad commented Feb 18, 2022 •
edited

157515d

Remove dormant queues from bot watchers dashboard
https://bugs.webkit.org/show_bug.cgi?id=236809

Reviewed by Alexey Proskuryakov.

* CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js:
* CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
* Tools/CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css:


Canonical link: https://commits.webkit.org/247655@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@ryanhaddad ryanhaddad self-assigned this Feb 18, 2022
aproskuryakov
aproskuryakov approved these changes Feb 18, 2022
View reviewed changes
Tools/CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css Outdated
@@ -221,10 +221,6 @@ table.queue-grid tr.platform.watchos-8 img.logo {
content: url(../Images/WatchOS8.png);
}

table.queue-grid tr.platform.macos-catalina img.logo {
content: url(../Images/Catalina.png);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this can be removed yet, isn't it used on other instances of the dashboard?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure we redefine this in other instances, and I haven't removed the image. I'll double check before landing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed.

@ryanhaddad ryanhaddad closed this Feb 22, 2022
@ryanhaddad ryanhaddad merged commit 157515d into WebKit:main Feb 22, 2022
@ryanhaddad
Copy link
Contributor Author

Landed https://commits.webkit.org/247655@main (157515d)!

@ryanhaddad ryanhaddad deleted the eng/236809-dashboard-cleanup branch February 22, 2022 23:03
@JonWBedard JonWBedard added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aproskuryakov aproskuryakov aproskuryakov approved these changes

@aj062 aj062 Awaiting requested review from aj062

Assignees

@ryanhaddad ryanhaddad

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
3 participants
@ryanhaddad @aproskuryakov @JonWBedard