Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ongamepadconnected + ongamepaddisconnected #1570

Merged
merged 1 commit into from Jul 11, 2022
Merged

Add ongamepadconnected + ongamepaddisconnected #1570

merged 1 commit into from Jul 11, 2022

Conversation

marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented Jun 16, 2022 •
edited by webkit-commit-queue

57f8b6a

Add ongamepadconnected + ongamepaddisconnected
https://bugs.webkit.org/show_bug.cgi?id=223860

Reviewed by Brady Eidson.

* LayoutTests/gamepad/gamepad-event-handlers-expected.txt: Added.
* LayoutTests/gamepad/gamepad-event-handlers.html: Added.
* LayoutTests/gamepad/gamepad-polling-access-expected.txt:
* LayoutTests/gamepad/gamepad-polling-access.html:
* LayoutTests/gamepad/gamepad-visibility-1.html:
* LayoutTests/platform/gtk/TestExpectations
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Modules/gamepad/WindowEventHandlers+Gamepad.idl: Added.
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/html/HTMLAttributeNames.in:

Canonical link: https://commits.webkit.org/252331@main

@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label Jun 16, 2022
@marcoscaceres marcoscaceres marked this pull request as ready for review June 17, 2022 07:49
@hortont424
Copy link
Contributor

Typo “diconnected” in title. Also I think we usually use 4-space indent (some of the tests are using 2).

@marcoscaceres marcoscaceres changed the title Add ongamepadconnected + ongamepaddiconnected Add ongamepadconnected + ongamepaddisconnected Jun 17, 2022
@marcoscaceres
Copy link
Contributor Author

Typo “diconnected” in title.

Oops, can someone fix that for me on bugzilla?

Also I think we usually use 4-space indent (some of the tests are using 2).

Will fix.

dcrousso
dcrousso reviewed Jun 17, 2022
View reviewed changes
Source/WebCore/WebCore.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
Source/WebCore/WebCore.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
Source/WebCore/WebCore.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
Source/WebCore/WebCore.xcodeproj/project.pbxproj Outdated
@@ -5531,6 +5531,8 @@
E7E0357224D4E196008DFEFB /* AnalyserOptions.h in Headers */ = {isa = PBXBuildFile; fileRef = E7E0357124D4E191008DFEFB /* AnalyserOptions.h */; };
E7FBE7C224EB2FB000A18E62 /* StereoPannerNode.h in Headers */ = {isa = PBXBuildFile; fileRef = E7FBE7C124EB2FAB00A18E62 /* StereoPannerNode.h */; };
E7FBE7C324EB2FB600A18E62 /* StereoPannerOptions.h in Headers */ = {isa = PBXBuildFile; fileRef = E7FBE7C024EB2FAB00A18E62 /* StereoPannerOptions.h */; };
E8FC921B285BFD5B004904B2 /* JSWindowEventHandlers+Gamepad.h in Product Dependencies */ = {isa = PBXBuildFile; fileRef = E8FC9219285BFD5A004904B2 /* JSWindowEventHandlers+Gamepad.h */; };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be added to 93F198A608245E59001E9ABC /* Headers */. I think you can do that by selecting this file in Xcode and checking the WebCore target in the details sidebar. You can also manually edit this file to add something like this

E8FC921B285BFD5B004904B2 /* JSWindowEventHandlers+Gamepad.h in Headers */,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I did it with the UI as you instructed just to be safe. Ut added it gave it a new hash and added it to headers, so hopefully that's right.

Source/WebCore/WebCore.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
@JonWBedard JonWBedard requested a review from beidson June 17, 2022 18:24
@marcoscaceres marcoscaceres changed the title Add ongamepadconnected + ongamepaddisconnected Add ongamepadconnected + ongamepaddiconnected Jun 20, 2022
@marcoscaceres marcoscaceres changed the title Add ongamepadconnected + ongamepaddiconnected Add ongamepadconnected + ongamepaddisconnected Jun 20, 2022
@marcoscaceres marcoscaceres changed the title Add ongamepadconnected + ongamepaddisconnected Add ongamepadconnected + ongamepaddiconnected Jun 20, 2022
@marcoscaceres marcoscaceres changed the title Add ongamepadconnected + ongamepaddiconnected Add ongamepadconnected + ongamepaddisconnected Jun 20, 2022
@marcoscaceres
Copy link
Contributor Author

marcoscaceres commented Jun 27, 2022 •
edited

@shivamidow, hi 👋 Sorry, to bother you, I'm a bit new to WebKit. I saw you implemented gamepad events for GTK in bug 133854. I'm hitting a gtk-wk2 test failure but I'm a bit unsure how to proceed. Could you provide me any guidance?

@shivamidow
Copy link
Member

Hey @marcoscaceres. You can skip the new tests by adding lines to LayoutTests/platform/gtk/TestExpectations. I will handle them later.

@marcoscaceres marcoscaceres added New Bugs Unclassified bugs are placed in this component until the correct component can be determined. Other and removed merging-blocked Applied to prevent a change from being merged labels Jul 6, 2022
@marcoscaceres
Copy link
Contributor Author

Thanks @shivamidow! I've excluded the test and filed https://webkit.org/b/242370

@marcoscaceres marcoscaceres added the merge-queue Applied to send a pull request to merge-queue label Jul 10, 2022
@webkit-commit-queue
Copy link
Collaborator

@marcoscaceres does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json.

If you do have committer permmissions, please ensure that your GitHub username is added to contributors.json.

Rejecting 47baa08d8108be860347cf17f47c9ee8dd7b68bd from merge queue.

@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Jul 10, 2022
@whsieh whsieh added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jul 10, 2022
@marcoscaceres @whsieh
Add ongamepadconnected + ongamepaddisconnected
57f8b6a 
https://bugs.webkit.org/show_bug.cgi?id=223860

Reviewed by Brady Eidson.

* LayoutTests/gamepad/gamepad-event-handlers-expected.txt: Added.
* LayoutTests/gamepad/gamepad-event-handlers.html: Added.
* LayoutTests/gamepad/gamepad-polling-access-expected.txt:
* LayoutTests/gamepad/gamepad-polling-access.html:
* LayoutTests/gamepad/gamepad-visibility-1.html:
* LayoutTests/platform/gtk/TestExpectations
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Modules/gamepad/WindowEventHandlers+Gamepad.idl: Added.
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/html/HTMLAttributeNames.in:

Canonical link: https://commits.webkit.org/252331@main
@webkit-commit-queue
Copy link
Collaborator

Committed 252331@main (57f8b6a): https://commits.webkit.org/252331@main

Reviewed commits have been landed. Closing PR #1570 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 57f8b6a into WebKit:main Jul 11, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcrousso dcrousso dcrousso left review comments

@beidson beidson beidson approved these changes

Assignees
No one assigned
Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
8 participants
@marcoscaceres @hortont424 @shivamidow @webkit-commit-queue @dcrousso @beidson @whsieh @webkit-early-warning-system