Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iPhone] 39miles.com link is rendered at single-column layout in private browsing mode #15763

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

whsieh
Copy link
Member

@whsieh whsieh commented Jul 12, 2023

88351af

[iPhone] 39miles.com link is rendered at single-column layout in private browsing mode
https://bugs.webkit.org/show_bug.cgi?id=259129
rdar://112105451

Reviewed by Aditya Keerthi.

Add a missing 390pt screen dimension breakpoint when advanced privacy protections are enabled;
currently, this causes some websites that rely on the screen width for layout to assume that the
width of the page is larger than it actually is.

* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::screenSizeForFingerprintingProtections const):
* Tools/TestWebKitAPI/Tests/WebKit/AdvancedPrivacyProtections.mm:

Also, augment an existing API test to verify that the new screen size breakpoint behaves as
expected.

Canonical link: https://commits.webkit.org/265979@main

608d5da

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe   πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2   πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1   πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
  πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@whsieh whsieh requested a review from cdumez as a code owner July 12, 2023 00:08
@whsieh whsieh self-assigned this Jul 12, 2023
@whsieh whsieh added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Jul 12, 2023
@whsieh
Copy link
Member Author

whsieh commented Jul 12, 2023

Thanks for the review!

@whsieh whsieh added the merge-queue Applied to send a pull request to merge-queue label Jul 12, 2023
…ate browsing mode

https://bugs.webkit.org/show_bug.cgi?id=259129
rdar://112105451

Reviewed by Aditya Keerthi.

Add a missing 390pt screen dimension breakpoint when advanced privacy protections are enabled;
currently, this causes some websites that rely on the screen width for layout to assume that the
width of the page is larger than it actually is.

* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::screenSizeForFingerprintingProtections const):
* Tools/TestWebKitAPI/Tests/WebKit/AdvancedPrivacyProtections.mm:

Also, augment an existing API test to verify that the new screen size breakpoint behaves as
expected.

Canonical link: https://commits.webkit.org/265979@main
@webkit-commit-queue
Copy link
Collaborator

Committed 265979@main (88351af): https://commits.webkit.org/265979@main

Reviewed commits have been landed. Closing PR #15763 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 88351af into WebKit:main Jul 12, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
4 participants