Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change how we rewind instructions in Air's O0 register allocator #1577

Merged
merged 0 commits into from Jun 16, 2022
Merged

Change how we rewind instructions in Air's O0 register allocator #1577

merged 0 commits into from Jun 16, 2022

Conversation

saambarati
Copy link
Contributor

@saambarati saambarati commented Jun 16, 2022 •
edited by webkit-early-warning-system

e07b5b9

Change how we rewind instructions in Air's O0 register allocator
https://bugs.webkit.org/show_bug.cgi?id=241687

Reviewed by Mark Lam.

* Source/JavaScriptCore/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp:
(JSC::B3::Air::GenerateAndAllocateRegisters::generate):

Canonical link: https://commits.webkit.org/251611@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@saambarati saambarati requested a review from a team as a code owner June 16, 2022 16:18
@saambarati saambarati self-assigned this Jun 16, 2022
@saambarati saambarati added JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. WebKit Nightly Build labels Jun 16, 2022
MenloDorian
MenloDorian approved these changes Jun 16, 2022
View reviewed changes
Copy link

@MenloDorian MenloDorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@saambarati saambarati added the merge-queue Applied to send a pull request to merge-queue label Jun 16, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Change-how-we-rewind-instructions-in-Airs-O0-register-allocator branch from 7afb521 to e07b5b9 Compare June 16, 2022 19:52
@webkit-early-warning-system webkit-early-warning-system merged commit e07b5b9 into WebKit:main Jun 16, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r295606 (251611@main): https://commits.webkit.org/251611@main

Reviewed commits have been landed. Closing PR #1577 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MenloDorian MenloDorian MenloDorian approved these changes

Assignees

@saambarati saambarati

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
3 participants
@saambarati @webkit-early-warning-system @MenloDorian