Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow access to power log service in internal builds #1578

Merged
merged 0 commits into from Jun 22, 2022
Merged

Allow access to power log service in internal builds #1578

merged 0 commits into from Jun 22, 2022

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented Jun 16, 2022 •
edited by webkit-commit-queue

ec2deb8

Allow access to power log service in internal builds
https://bugs.webkit.org/show_bug.cgi?id=241688
<rdar://82442196>

Reviewed by Geoffrey Garen.

Allow access to power log service in the GPU process in internal builds.

* Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

Canonical link: https://commits.webkit.org/251710@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@pvollan pvollan self-assigned this Jun 16, 2022
@pvollan pvollan added Safari 15 WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). labels Jun 16, 2022
geoffreygaren
geoffreygaren approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@geoffreygaren geoffreygaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

Is there anything we can do to narrow the scope of this exception? For example, can we issue a sandbox extension if and only if power log tasking is enabled?

@pvollan
Copy link
Contributor Author

pvollan commented Jun 17, 2022

r=me

Is there anything we can do to narrow the scope of this exception? For example, can we issue a sandbox extension if and only if power log tasking is enabled?

That is a good point. After the change in #1243 landed, we already do this on non internal builds. Do you mean having the same behavior on internal builds?

Thanks for reviewing!

@pvollan pvollan added merge-queue Applied to send a pull request to merge-queue and removed merge-queue Applied to send a pull request to merge-queue labels Jun 18, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Allow-access-to-power-log-service-in-internal-builds branch from eb13c23 to ec2deb8 Compare June 22, 2022 00:18
@webkit-commit-queue webkit-commit-queue merged commit ec2deb8 into WebKit:main Jun 22, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed r295705 (251710@main): https://commits.webkit.org/251710@main

Reviewed commits have been landed. Closing PR #1578 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreygaren geoffreygaren geoffreygaren approved these changes

@szewai szewai Awaiting requested review from szewai

@bnham bnham Awaiting requested review from bnham

Assignees

@pvollan pvollan

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@pvollan @webkit-commit-queue @geoffreygaren @webkit-early-warning-system