Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EWS] Enable GTK and Windows queues for PRs #158

Merged
merged 0 commits into from Feb 21, 2022

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Feb 18, 2022

dae8055

[EWS] Enable GTK and Windows queues for PRs
https://bugs.webkit.org/show_bug.cgi?id=236814
<rdar://problem/89117205 >

Reviewed by Ryan Haddad.

* Tools/CISupport/ews-build/config.json:


Canonical link: https://commits.webkit.org/247568@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@JonWBedard JonWBedard self-assigned this Feb 18, 2022
@aj062
Copy link
Member

aj062 commented Feb 18, 2022

I think windows queue should be fine, as it probably doesn't do anything unique. But we should check "GTK-WK2-Tests-EWS" which is triggered by "GTK-Build-EWS". I think that queue has few unique build-steps. You can probably test it on uat instance by smartly re-using the igalia bots which are connected there.

@lauromoura
Copy link
Contributor

I think windows queue should be fine, as it probably doesn't do anything unique. But we should check "GTK-WK2-Tests-EWS" which is triggered by "GTK-Build-EWS". I think that queue has few unique build-steps. You can probably test it on uat instance by smartly re-using the igalia bots which are connected there.

Yes. It uses the RunWebKitTestsRedTree factory to get real regressions out of a currently red tree, iterating a few times on a subset of the tests in case of failures.

@JonWBedard
Copy link
Member Author

I think windows queue should be fine, as it probably doesn't do anything unique. But we should check "GTK-WK2-Tests-EWS" which is triggered by "GTK-Build-EWS". I think that queue has few unique build-steps. You can probably test it on uat instance by smartly re-using the igalia bots which are connected there.

Yes. It uses the RunWebKitTestsRedTree factory to get real regressions out of a currently red tree, iterating a few times on a subset of the tests in case of failures.

Ok, will hold off landing this until we test GTK testers on the UAT instance.

@JonWBedard JonWBedard force-pushed the eng/github-ews-enablle-gtk-windows branch from 9de8191 to ba4d088 Compare February 18, 2022 16:00
@JonWBedard
Copy link
Member Author

I deployed this change this morning to see how GTK bots were performing since I figured we wouldn't have much to test. Everything looks to be behaving correctly, see #161, I will be landing this Monday morning. If we have problems, we can disable the queue, but I don't think we will.

@JonWBedard JonWBedard closed this Feb 21, 2022
@JonWBedard JonWBedard merged commit dae8055 into WebKit:main Feb 21, 2022
@JonWBedard JonWBedard force-pushed the eng/github-ews-enablle-gtk-windows branch from ba4d088 to dae8055 Compare February 21, 2022 15:20
@JonWBedard
Copy link
Member Author

Landed https://commits.webkit.org/247568@main (dae8055)!

@JonWBedard JonWBedard deleted the eng/github-ews-enablle-gtk-windows branch February 21, 2022 15:20
@JonWBedard JonWBedard added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
4 participants