Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLIB] Initialize FILE* attributes to nullptr in CGroupMemoryController #15816

Merged
merged 1 commit into from
Jul 13, 2023
Merged

[GLIB] Initialize FILE* attributes to nullptr in CGroupMemoryController #15816

merged 1 commit into from
Jul 13, 2023

Conversation

psaavedra
Copy link
Contributor

@psaavedra psaavedra commented Jul 13, 2023 •
edited by webkit-early-warning-system
Loading

0cda937

[GLIB] Initialize FILE* attributes to nullptr in CGroupMemoryController
https://bugs.webkit.org/show_bug.cgi?id=259185

Reviewed by Carlos Alberto Lopez Perez.

... since the CGroupMemoryController FILE* attributes are not inmediatelly
initialized during the construction but after the creation when
setMemoryControllerPath() is called.

* Source/WebKit/UIProcess/linux/MemoryPressureMonitor.h:

Canonical link: https://commits.webkit.org/266031@main

1970e2c

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
❌ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@psaavedra psaavedra requested a review from a team as a code owner July 13, 2023 10:35
@psaavedra psaavedra self-assigned this Jul 13, 2023
@psaavedra psaavedra added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Jul 13, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 13, 2023 •
edited
Loading

EWS run on current version of this PR (hash 1970e2c)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
❌ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@psaavedra psaavedra added the merge-queue Applied to send a pull request to merge-queue label Jul 13, 2023
@webkit-commit-queue webkit-commit-queue force-pushed the eng/GLIB-Initialize-FILE-attributes-to-nullptr-in-CGroupMemoryController branch from 1970e2c to 09eafda Compare July 13, 2023 13:50
@psaavedra
[GLIB] Initialize FILE* attributes to nullptr in CGroupMemoryController
0cda937 
https://bugs.webkit.org/show_bug.cgi?id=259185

Reviewed by Carlos Alberto Lopez Perez.

... since the CGroupMemoryController FILE* attributes are not inmediatelly
initialized during the construction but after the creation when
setMemoryControllerPath() is called.

* Source/WebKit/UIProcess/linux/MemoryPressureMonitor.h:

Canonical link: https://commits.webkit.org/266031@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/GLIB-Initialize-FILE-attributes-to-nullptr-in-CGroupMemoryController branch from 09eafda to 0cda937 Compare July 13, 2023 13:53
@webkit-commit-queue
Copy link
Collaborator

Committed 266031@main (0cda937): https://commits.webkit.org/266031@main

Reviewed commits have been landed. Closing PR #15816 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0cda937 into WebKit:main Jul 13, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clopez clopez clopez approved these changes

Assignees

@psaavedra psaavedra

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@psaavedra @webkit-early-warning-system @webkit-commit-queue @clopez