[ WK2 ] http/wpt/webcodecs/videoFrame-video-element.html is a flaky TEXT failure #15974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 0a6798f)
|
youennf
force-pushed
the
eng/-WK2--httpwptwebcodecsvideoFrame-video-element-html-is-a-flaky-TEXT-failure
branch
from
0a6798f
to
acd7ea8
Compare
|
EWS run on previous version of this PR (hash acd7ea8)
|
webkit-ews-buildbot
added
the
merging-blocked
youennf
removed
the
merging-blocked
eric-carlson
approved these changes
Jul 25, 2023
bls1999
force-pushed
the
eng/-WK2--httpwptwebcodecsvideoFrame-video-element-html-is-a-flaky-TEXT-failure
branch
2 times, most recently
from
a0b4e08
to
97ff584
Compare
|
EWS run on current version of this PR (hash 97ff584)
|
…EXT failure https://bugs.webkit.org/show_bug.cgi?id=259379 rdar://112628818 Reviewed by Eric Carlson. GPUProcess is sending to WebProcess MediaPlayer::ReadyState::HaveCurrentData signal even if it has not yet received any video frame in the output queue. This creates a race between WebProcess firing the loadeddata event and creation of a VideoFrame object from the media element and GPUProcess actually getting the underlying pixel buffer. Before the patch, creation of the VideoFrame object would sometimes fail if the WebProcess wins the race. To prevent this, if there is no pixel buffer, we wait for one. This makes the WebProcess sync IPC wait a little bit longer in some cases. Covered by http/wpt/webcodecs/videoFrame-video-element.html no longer being flaky locally. * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac-wk2/TestExpectations: * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::videoFrameForCurrentTime): Canonical link: https://commits.webkit.org/268339@main
webkit-commit-queue
force-pushed
the
eng/-WK2--httpwptwebcodecsvideoFrame-video-element-html-is-a-flaky-TEXT-failure
branch
from
97ff584
to
1d29e0e
Compare
|
Committed 268339@main (1d29e0e): https://commits.webkit.org/268339@main Reviewed commits have been landed. Closing PR #15974 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1d29e0e
97ff584
🛠 wincairo🧪 wpe-wk2🛠 gtk🧪 mac-wk1🧪 gtk-wk2🧪 api-gtk🛠 tv🧪 mac-AS-debug-wk2🛠 watch-sim