Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build against libjxl 0.9 #15983

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Build against libjxl 0.9 #15983

merged 1 commit into from
Jul 24, 2023

Conversation

mcatanzaro
Copy link
Contributor

@mcatanzaro mcatanzaro commented Jul 21, 2023 •
edited by webkit-early-warning-system
Loading

bc4e645

Build against libjxl 0.9
https://bugs.webkit.org/show_bug.cgi?id=259393

Reviewed by Carlos Garcia Campos.

As libjxl works towards version 1.0, there are still API/ABI breaks on
every 0.n release. libjxl 0.9 removed an unused parameter to some ICC
functions we depend on.

* Source/WebCore/platform/image-decoders/jpegxl/JPEGXLImageDecoder.cpp:
(WebCore::JPEGXLImageDecoder::tryDecodeICCColorProfile):

Canonical link: https://commits.webkit.org/266244@main

196caf3

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mcatanzaro mcatanzaro self-assigned this Jul 21, 2023
@mcatanzaro mcatanzaro added the Images For bugs in image handling. label Jul 21, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 21, 2023 •
edited
Loading

EWS run on current version of this PR (hash 196caf3)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jul 21, 2023
@mcatanzaro mcatanzaro added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jul 24, 2023
@mcatanzaro
Build against libjxl 0.9
bc4e645 
https://bugs.webkit.org/show_bug.cgi?id=259393

Reviewed by Carlos Garcia Campos.

As libjxl works towards version 1.0, there are still API/ABI breaks on
every 0.n release. libjxl 0.9 removed an unused parameter to some ICC
functions we depend on.

* Source/WebCore/platform/image-decoders/jpegxl/JPEGXLImageDecoder.cpp:
(WebCore::JPEGXLImageDecoder::tryDecodeICCColorProfile):

Canonical link: https://commits.webkit.org/266244@main
@webkit-commit-queue
Copy link
Collaborator

Committed 266244@main (bc4e645): https://commits.webkit.org/266244@main

Reviewed commits have been landed. Closing PR #15983 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit bc4e645 into WebKit:main Jul 24, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosgcampos carlosgcampos carlosgcampos approved these changes

Assignees

@mcatanzaro mcatanzaro

Labels
Images For bugs in image handling.
Projects
None yet
Milestone
No milestone
5 participants
@mcatanzaro @webkit-early-warning-system @webkit-commit-queue @carlosgcampos @webkit-ews-buildbot