Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some security tests after 266167@main #16013

Conversation

achristensen07
Copy link
Contributor

@achristensen07 achristensen07 commented Jul 22, 2023

f504bf1

Fix some security tests after 266167@main
https://bugs.webkit.org/show_bug.cgi?id=259417

Unreviewed.

266167@main changed Cocoa's WebKitTestRunner's preferences management
from copying from the newly allocated WKWebViewConfiguration to copying
from the long-living WKPreferencesRef to the newly allocated WKWebViewConfiguration.
This made it so that state set in previous test runs was being carried forward
to future test runs done with the same WebKitTestRunner instance.
This just reverses the copying back to how it was before 266167@main.
I verified this fixes the tests Fujii noticed in https://bugs.webkit.org/show_bug.cgi?id=259324

* Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::initializeWebViewConfiguration):
(WTR::TestController::platformAdjustContext):

Canonical link: https://commits.webkit.org/266231@main

3cd2028

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1   πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2   πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  watch
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim

@achristensen07 achristensen07 self-assigned this Jul 22, 2023
@achristensen07 achristensen07 added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jul 22, 2023
@achristensen07 achristensen07 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 22, 2023
https://bugs.webkit.org/show_bug.cgi?id=259417

Unreviewed.

266167@main changed Cocoa's WebKitTestRunner's preferences management
from copying from the newly allocated WKWebViewConfiguration to copying
from the long-living WKPreferencesRef to the newly allocated WKWebViewConfiguration.
This made it so that state set in previous test runs was being carried forward
to future test runs done with the same WebKitTestRunner instance.
This just reverses the copying back to how it was before 266167@main.
I verified this fixes the tests Fujii noticed in https://bugs.webkit.org/show_bug.cgi?id=259324

* Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::initializeWebViewConfiguration):
(WTR::TestController::platformAdjustContext):

Canonical link: https://commits.webkit.org/266231@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Fix-some-security-tests-after-266167main branch from 3cd2028 to f504bf1 Compare July 22, 2023 18:50
@webkit-commit-queue
Copy link
Collaborator

Committed 266231@main (f504bf1): https://commits.webkit.org/266231@main

Reviewed commits have been landed. Closing PR #16013 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f504bf1 into WebKit:main Jul 22, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
3 participants