Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of asm.putsLabel #16043

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Fix usage of asm.putsLabel #16043

merged 1 commit into from
Jul 25, 2023

Conversation

danlliu
Copy link
Contributor

@danlliu danlliu commented Jul 24, 2023 •
edited by webkit-early-warning-system
Loading

87119fe

Fix usage of asm.putsLabel
https://bugs.webkit.org/show_bug.cgi?id=259453
rdar://112798638

Reviewed by Yusuke Suzuki and Justin Michaud.

Fixes an oversight in #15659 where a putsLabel call was missing the aligned parameter.

* Source/JavaScriptCore/offlineasm/cloop.rb:

Canonical link: https://commits.webkit.org/266272@main

e54176f

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios   🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv   🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@danlliu danlliu requested a review from a team as a code owner July 24, 2023 22:17
@danlliu danlliu self-assigned this Jul 24, 2023
@danlliu danlliu added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Jul 24, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 24, 2023 •
edited
Loading

EWS run on current version of this PR (hash e54176f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios   🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv   🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

justinmichaud
justinmichaud approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@justinmichaud justinmichaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

Constellation
Constellation approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 24, 2023
@danlliu @Constellation
Fix usage of asm.putsLabel
87119fe 
https://bugs.webkit.org/show_bug.cgi?id=259453
rdar://112798638

Reviewed by Yusuke Suzuki and Justin Michaud.

Fixes an oversight in WebKit#15659 where a putsLabel call was missing the aligned parameter.

* Source/JavaScriptCore/offlineasm/cloop.rb:

Canonical link: https://commits.webkit.org/266272@main
@webkit-commit-queue
Copy link
Collaborator

Committed 266272@main (87119fe): https://commits.webkit.org/266272@main

Reviewed commits have been landed. Closing PR #16043 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 87119fe into WebKit:main Jul 25, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Constellation Constellation Constellation approved these changes

@justinmichaud justinmichaud justinmichaud approved these changes

Assignees

@danlliu danlliu

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
5 participants
@danlliu @webkit-early-warning-system @webkit-commit-queue @Constellation @justinmichaud