Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProcessThrottler should use smart pointers instead of raw pointers #16082

Merged
merged 1 commit into from
Aug 1, 2023
Merged

ProcessThrottler should use smart pointers instead of raw pointers #16082

merged 1 commit into from
Aug 1, 2023

Conversation

rniwa
Copy link
Member

@rniwa rniwa commented Jul 25, 2023 •
edited by webkit-early-warning-system
Loading

0d88eeb

ProcessThrottler should use smart pointers instead of raw pointers
https://bugs.webkit.org/show_bug.cgi?id=259500

Reviewed by Chris Dumez.

Deploy smart pointers around ProcessThrottler.

* Source/WebKit/UIProcess/ProcessThrottler.cpp:
(WebKit::ProcessThrottler::addActivity):
(WebKit::ProcessThrottler::removeActivity):
(WebKit::ProcessThrottler::invalidateAllActivities):
(WebKit::ProcessThrottler::expectedThrottleState):
(WebKit::ProcessThrottler::setThrottleState):
(WebKit::ProcessThrottler::setAllowsActivities):
(WebKit::logActivityNames):
* Source/WebKit/UIProcess/ProcessThrottler.h:
(WebKit::ProcessThrottlerTimedActivity::activity const):
(WebKit::ProcessThrottler::shouldBeRunnable const):

Canonical link: https://commits.webkit.org/266496@main

64a641b

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@rniwa rniwa requested a review from cdumez as a code owner July 25, 2023 22:26
@rniwa rniwa self-assigned this Jul 25, 2023
@rniwa rniwa added the WebKit2 Bugs relating to the WebKit2 API layer label Jul 25, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 25, 2023 •
edited
Loading

EWS run on current version of this PR (hash 64a641b)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

cdumez
cdumez approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@cdumez cdumez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 1, 2023
@rniwa
ProcessThrottler should use smart pointers instead of raw pointers
0d88eeb 
https://bugs.webkit.org/show_bug.cgi?id=259500

Reviewed by Chris Dumez.

Deploy smart pointers around ProcessThrottler.

* Source/WebKit/UIProcess/ProcessThrottler.cpp:
(WebKit::ProcessThrottler::addActivity):
(WebKit::ProcessThrottler::removeActivity):
(WebKit::ProcessThrottler::invalidateAllActivities):
(WebKit::ProcessThrottler::expectedThrottleState):
(WebKit::ProcessThrottler::setThrottleState):
(WebKit::ProcessThrottler::setAllowsActivities):
(WebKit::logActivityNames):
* Source/WebKit/UIProcess/ProcessThrottler.h:
(WebKit::ProcessThrottlerTimedActivity::activity const):
(WebKit::ProcessThrottler::shouldBeRunnable const):

Canonical link: https://commits.webkit.org/266496@main
@webkit-commit-queue
Copy link
Collaborator

Committed 266496@main (0d88eeb): https://commits.webkit.org/266496@main

Reviewed commits have been landed. Closing PR #16082 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0d88eeb into WebKit:main Aug 1, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 1, 2023
@rniwa rniwa deleted the fix259500 branch May 21, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

@salinas-miguel salinas-miguel Awaiting requested review from salinas-miguel

Assignees

@rniwa rniwa

Labels
WebKit2 Bugs relating to the WebKit2 API layer
Projects
None yet
Milestone
No milestone
4 participants
@rniwa @webkit-early-warning-system @webkit-commit-queue @cdumez