New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set intrinsic size for inline SVG earlier #16084
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
Ahmad-S792:fix257614-svg-inline-fix
Jul 26, 2023
Merged
Set intrinsic size for inline SVG earlier #16084
webkit-commit-queue
merged 1 commit into
WebKit:main
from
Ahmad-S792:fix257614-svg-inline-fix
Jul 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash 9679569) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Jul 25, 2023
Ahmad-S792
force-pushed
the
fix257614-svg-inline-fix
branch
from
July 25, 2023 23:18
9679569
to
c09fd76
Compare
Ahmad-S792
removed
the
merging-blocked
Applied to prevent a change from being merged
label
Jul 25, 2023
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Jul 25, 2023
Ahmad-S792
force-pushed
the
fix257614-svg-inline-fix
branch
from
July 25, 2023 23:22
c09fd76
to
7b4ceb3
Compare
EWS run on previous version of this PR (hash 7b4ceb3) |
Ahmad-S792
removed
the
merging-blocked
Applied to prevent a change from being merged
label
Jul 25, 2023
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Jul 25, 2023
Ahmad-S792
force-pushed
the
fix257614-svg-inline-fix
branch
from
July 25, 2023 23:27
7b4ceb3
to
510ccba
Compare
EWS run on current version of this PR (hash 510ccba) |
Ahmad-S792
removed
the
merging-blocked
Applied to prevent a change from being merged
label
Jul 25, 2023
smfr
approved these changes
Jul 26, 2023
https://bugs.webkit.org/show_bug.cgi?id=257614 rdar://problem/110480382 Reviewed by Simon Fraser. This patch aligns WebKit with Gecko / Firefox and Blink / Chromium. Merge: https://chromium.googlesource.com/chromium/src.git/+/545b2183e1b4ee3eb433537f9a6386b5337d6588 RenderReplaced has a m_intrinsicSize that's updated when computing logical widths and heights (and only if needed; specified style makes it not being set at all). But m_intrinsicSize can be used earlier that that, when computing preferred widths for the container, see RenderReplaced::computeIntrinsicLogicalWidths called from RenderReplaced::computePreferredLogicalWidths(). This patch computes the intrinsic size in the constructor to avoid returning the stale default size. * Source/WebCore/rendering/svg/LegacyRenderSVGRoot.cpp: (1) Add constants for 'defaultWidth' and 'defaultHeight' (2) Add 'intrinsicSize' logic (3) Introduce new function 'calculateIntrinsicSize' (LegacyRenderSVGRoot::computeIntrinsicRatioInformation): Call above function and remove unneeded comments * Source/WebCore/rendering/svg/LegacyRenderSVGRoot.h: Definition of 'calculateIntrinsicSize' * Source/WebCore/rendering/svg/RenderSVGRoot.cpp: Same changes as 'Legacy' for LBSE * Source/WebCore/rendering/svg/RenderSVGRoot.h: Ditto * LayoutTests/svg/in-html/inside-inline-block.html: Add Test Case * LayoutTests/svg/in-html/inside-inline-block-expected.html: Add Test Case Expectation Canonical link: https://commits.webkit.org/266314@main
webkit-commit-queue
force-pushed
the
fix257614-svg-inline-fix
branch
from
July 26, 2023 15:49
510ccba
to
dbdb89f
Compare
Committed 266314@main (dbdb89f): https://commits.webkit.org/266314@main Reviewed commits have been landed. Closing PR #16084 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbdb89f
510ccba