[popover] Using shadow DOM wrongly auto-hides popover by light dismiss #16234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 59f2c6c)
|
nt1m
added
the
DOM
darinadler
approved these changes
Jul 31, 2023
Source/WebCore/dom/Document.cpp
Outdated
| for (auto& element : lineageOfType<HTMLElement>(*startElement)) { | ||
| if (!clickedPopover && isShowingAutoPopover(element)) | ||
| clickedPopover = &element; | ||
| for (auto* element = startElement; element; element = element->parentElementInComposedTree()) { |
There was a problem hiding this comment.
Unfortunate that we don’t have a lineageOfType function that works with the composed tree.
Source/WebCore/dom/Document.cpp
Outdated
| if (!is<HTMLElement>(element)) | ||
| continue; | ||
|
|
||
| auto* htmlElement = downcast<HTMLElement>(element); |
There was a problem hiding this comment.
Two choices that are better style: use dynamicDowncast and check for nullptr rather than using both is and downcast, or use is and downcast, but pass a reference instead of a pointer to downcast.
rniwa
approved these changes
Jul 31, 2023
rniwa
approved these changes
Jul 31, 2023
nt1m
force-pushed
the
eng/popover-element-within-shadow-DOM-breaks-light-dismiss-calculation
branch
from
59f2c6c
to
4902c27
Compare
|
EWS run on current version of this PR (hash 4902c27) |
https://bugs.webkit.org/show_bug.cgi?id=259261 rdar://112410375 Reviewed by Ryosuke Niwa and Darin Adler. Use the flat tree as mandated by the spec when calculating which popover to light dismiss: - https://html.spec.whatwg.org/#topmost-clicked-popover - https://html.spec.whatwg.org/#nearest-inclusive-open-popover - https://html.spec.whatwg.org/#nearest-inclusive-target-popover-for-invoker * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-flat-tree-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-flat-tree.html: Added. * Source/WebCore/dom/Document.cpp: (WebCore::Document::handlePopoverLightDismiss): Canonical link: https://commits.webkit.org/266457@main
webkit-commit-queue
force-pushed
the
eng/popover-element-within-shadow-DOM-breaks-light-dismiss-calculation
branch
from
4902c27
to
9336846
Compare
|
Committed 266457@main (9336846): https://commits.webkit.org/266457@main Reviewed commits have been landed. Closing PR #16234 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
nt1m
deleted the
eng/popover-element-within-shadow-DOM-breaks-light-dismiss-calculation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9336846
4902c27
🛠 wincairo🧪 wpe-wk2🧪 ios-wk2-wpt🧪 gtk-wk2