Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AR issues. Right after opening the USDZ and GLB file in the browser, it closes itself #16254

Merged
merged 1 commit into from
Aug 1, 2023
Merged

AR issues. Right after opening the USDZ and GLB file in the browser, it closes itself #16254

merged 1 commit into from
Aug 1, 2023

Conversation

grorg
Copy link
Contributor

@grorg grorg commented Jul 31, 2023 •
edited by webkit-early-warning-system
Loading

416f234

AR issues. Right after opening the USDZ and GLB file in the browser, it closes itself
https://bugs.webkit.org/show_bug.cgi?id=259670
rdar://110978209

Reviewed by Tim Horton.

We tightened the list of MIME types we accepted in ARQL during
the past year. Unfortunately still many servers are not configured
to send USD with the correct type, so we need to relax the list
a bit. For now, we'll add "application/octet-stream".

Added a new API test for this case.

* Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/266462@main

0082bd1

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@grorg grorg requested a review from cdumez as a code owner July 31, 2023 23:47
@grorg grorg self-assigned this Jul 31, 2023
@grorg grorg added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Jul 31, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 31, 2023 •
edited
Loading

EWS run on current version of this PR (hash 0082bd1)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@grorg grorg requested a review from hortont424 July 31, 2023 23:48
@grorg grorg added the merge-queue Applied to send a pull request to merge-queue label Jul 31, 2023
@grorg
AR issues. Right after opening the USDZ and GLB file in the browser, …
416f234 
…it closes itself

https://bugs.webkit.org/show_bug.cgi?id=259670
rdar://110978209

Reviewed by Tim Horton.

We tightened the list of MIME types we accepted in ARQL during
the past year. Unfortunately still many servers are not configured
to send USD with the correct type, so we need to relax the list
a bit. For now, we'll add "application/octet-stream".

Added a new API test for this case.

* Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/266462@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/AR-issues--Right-after-opening-the-USDZ-and-GLB-file-in-the-browser-it-closes-itself branch from 0082bd1 to 416f234 Compare August 1, 2023 01:07
@webkit-commit-queue
Copy link
Collaborator

Committed 266462@main (416f234): https://commits.webkit.org/266462@main

Reviewed commits have been landed. Closing PR #16254 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 416f234 into WebKit:main Aug 1, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 1, 2023
@grorg grorg deleted the eng/AR-issues--Right-after-opening-the-USDZ-and-GLB-file-in-the-browser-it-closes-itself branch August 1, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hortont424 hortont424 hortont424 approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@grorg grorg

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@grorg @webkit-early-warning-system @webkit-commit-queue @hortont424