REGRESSION(262797@main): Menu permanently opened on github.com

[carlosgcampos]

476e8fb

REGRESSION(262797@main): Menu permanently opened on github.com
https://bugs.webkit.org/show_bug.cgi?id=258290

Reviewed by Michael Catanzaro.

In 262797@main popover attribute was disabled for apple apps linkking to
the older SDKs, but also for non-apple ports. What happens in github now
is that the popover is never hidden because display: revert ends up in
block. This is because the popover css, which sets display: none when
popover-open is not present, is not included for any element.

* Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultPopoverAttributeEnabled): Enable it by default for non-apple ports again.

Canonical link: https://commits.webkit.org/266510@main

6a83f3e

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt		✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash 6a83f3e)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt		✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

[mcatanzaro]

My hero!

fyi: @nt1m

[webkit-commit-queue]

Committed 266510@main (476e8fb): https://commits.webkit.org/266510@main

Reviewed commits have been landed. Closing PR #16309 and removing active labels.

[nt1m]

Sorry about that, thanks for fixing !