Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[import-w3c-tests] Be stricter about argument parsing #16331

Merged

Conversation

gsnedders
Copy link
Contributor

@gsnedders gsnedders commented Aug 2, 2023

b696c86

[import-w3c-tests] Be stricter about argument parsing
https://bugs.webkit.org/show_bug.cgi?id=259750
rdar://problem/113293027

Reviewed by Jonathan Bedard.

This moves us to using argparse.ArgumentParser.parse_args instead of
argparse.ArgumentParser.parse_known_args, thereby resulting in unknown
arguments causing an error.

Additionally, add an error when you pass a test_path that doesn't
start with web-platform-test/, as this is practically required.

* Tools/Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.do_import):
* Tools/Scripts/webkitpy/w3c/test_importer_unittest.py:

Canonical link: https://commits.webkit.org/266587@main

2556334

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ webkitpy βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  watch
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim

@gsnedders gsnedders self-assigned this Aug 2, 2023
@gsnedders gsnedders added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Aug 2, 2023
@gsnedders gsnedders force-pushed the import-w3c-tests-invalid-args branch from a45997a to 2556334 Compare August 2, 2023 23:02
@gsnedders
Copy link
Contributor Author

(code style violation is deliberate to match local style, without reformatting quite a lot more)

@gsnedders gsnedders added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 4, 2023
https://bugs.webkit.org/show_bug.cgi?id=259750
rdar://problem/113293027

Reviewed by Jonathan Bedard.

This moves us to using argparse.ArgumentParser.parse_args instead of
argparse.ArgumentParser.parse_known_args, thereby resulting in unknown
arguments causing an error.

Additionally, add an error when you pass a test_path that doesn't
start with web-platform-test/, as this is practically required.

* Tools/Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.do_import):
* Tools/Scripts/webkitpy/w3c/test_importer_unittest.py:

Canonical link: https://commits.webkit.org/266587@main
@webkit-commit-queue
Copy link
Collaborator

Committed 266587@main (b696c86): https://commits.webkit.org/266587@main

Reviewed commits have been landed. Closing PR #16331 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b696c86 into WebKit:main Aug 4, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 4, 2023
@gsnedders gsnedders deleted the import-w3c-tests-invalid-args branch August 4, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
4 participants