-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[import-w3c-tests] Be stricter about argument parsing #16331
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
gsnedders:import-w3c-tests-invalid-args
Aug 4, 2023
Merged
[import-w3c-tests] Be stricter about argument parsing #16331
webkit-commit-queue
merged 1 commit into
WebKit:main
from
gsnedders:import-w3c-tests-invalid-args
Aug 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsnedders
added
the
Tools / Tests
Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
label
Aug 2, 2023
EWS run on previous version of this PR (hash a45997a) |
gsnedders
force-pushed
the
import-w3c-tests-invalid-args
branch
from
August 2, 2023 23:02
a45997a
to
2556334
Compare
EWS run on current version of this PR (hash 2556334) |
(code style violation is deliberate to match local style, without reformatting quite a lot more) |
JonWBedard
approved these changes
Aug 4, 2023
gsnedders
added
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Aug 4, 2023
https://bugs.webkit.org/show_bug.cgi?id=259750 rdar://problem/113293027 Reviewed by Jonathan Bedard. This moves us to using argparse.ArgumentParser.parse_args instead of argparse.ArgumentParser.parse_known_args, thereby resulting in unknown arguments causing an error. Additionally, add an error when you pass a test_path that doesn't start with web-platform-test/, as this is practically required. * Tools/Scripts/webkitpy/w3c/test_importer.py: (TestImporter.do_import): * Tools/Scripts/webkitpy/w3c/test_importer_unittest.py: Canonical link: https://commits.webkit.org/266587@main
webkit-commit-queue
force-pushed
the
import-w3c-tests-invalid-args
branch
from
August 4, 2023 17:01
2556334
to
b696c86
Compare
Committed 266587@main (b696c86): https://commits.webkit.org/266587@main Reviewed commits have been landed. Closing PR #16331 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Tools / Tests
Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b696c86
2556334