Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputDevice capabilities are not required until capture is active #16380

Conversation

eric-carlson
Copy link
Contributor

@eric-carlson eric-carlson commented Aug 4, 2023

a41543c

InputDevice capabilities are not required until capture is active
https://bugs.webkit.org/show_bug.cgi?id=259814
rdar://113271473

Reviewed by Jer Noble.

InputDevice capabilities are not exposed until after the user has given consent to
capture, so don't bother asking for them unless they will be revealed as activating the
AVAudioSession may change the characteristics of the audio rendering in other processes.

* Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::platformGetMediaStreamDevices):

Canonical link: https://commits.webkit.org/266581@main

e401f76

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@eric-carlson eric-carlson self-assigned this Aug 4, 2023
@eric-carlson eric-carlson added the WebRTC For bugs in WebRTC label Aug 4, 2023
@eric-carlson eric-carlson added the merge-queue Applied to send a pull request to merge-queue label Aug 4, 2023
https://bugs.webkit.org/show_bug.cgi?id=259814
rdar://113271473

Reviewed by Jer Noble.

InputDevice capabilities are not exposed until after the user has given consent to
capture, so don't bother asking for them unless they will be revealed as activating the
AVAudioSession may change the characteristics of the audio rendering in other processes.

* Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::platformGetMediaStreamDevices):

Canonical link: https://commits.webkit.org/266581@main
@webkit-commit-queue
Copy link
Collaborator

Committed 266581@main (a41543c): https://commits.webkit.org/266581@main

Reviewed commits have been landed. Closing PR #16380 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit a41543c into WebKit:main Aug 4, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebRTC For bugs in WebRTC
Projects
None yet
4 participants