-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace EventLoopTimerPtr with EventLoopTimerHandle #16498
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash 0cdc0e5) |
whsieh
approved these changes
Aug 9, 2023
EWS run on previous version of this PR (hash 2081eab) |
EWS run on current version of this PR (hash ec8656b) |
https://bugs.webkit.org/show_bug.cgi?id=259955 Reviewed by Wenson Hsieh. This PR replaces EventLoopTimerPtr, which is a type cast of EventLoopTimer*, with a proper EventLoopTimerHandle which knows how to clean up itself at the end. EventLoopTimerHandle is simply a wrapper around RefPtr<EventLoopTimer> now that EventLoopTimer is reference counted. This PR also removes cancelScheduledTask and cancelRepeatingTask from EventLoop and EventLoopTaskGroup as the timer is automatically deleted when the handle dies. * Source/WebCore/dom/EventLoop.cpp: (WebCore::EventLoopTimerHandle::EventLoopTimerHandle): (WebCore::EventLoopTimerHandle::~EventLoopTimerHandle): (WebCore::EventLoopTimerHandle::operator=): (WebCore::EventLoop::scheduleTask): (WebCore::EventLoop::cancelScheduledTask): Deleted. (WebCore::EventLoop::removeScheduledTimer): (WebCore::EventLoop::didExecuteScheduledTask): Deleted. (WebCore::EventLoop::scheduleRepeatingTask): (WebCore::EventLoop::cancelRepeatingTask): Deleted. (WebCore::EventLoop::removeRepeatingTimer): (WebCore::EventLoopTaskGroup::scheduleTask):. (WebCore::EventLoopTaskGroup::cancelScheduledTask): Deleted. (WebCore::EventLoopTaskGroup::didExecuteScheduledTask): Deleted. (WebCore::EventLoopTaskGroup::removeScheduledTimer): (WebCore::EventLoopTaskGroup::scheduleRepeatingTask): (WebCore::EventLoopTaskGroup::cancelRepeatingTask): Deleted. (WebCore::EventLoopTaskGroup::removeRepeatingTimer): * Source/WebCore/dom/EventLoop.h: (WebCore::EventLoopTimerHandle::operator UnspecifiedBoolType const): (WebCore::EventLoopTimerHandle::unspecifiedBoolTypeInstance const): * Source/WebCore/editing/AlternativeTextController.cpp: (WebCore::AlternativeTextController::stopAlternativeTextUITimer): * Source/WebCore/editing/AlternativeTextController.h: * Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::maybeRestoreContextSoon): * Source/WebCore/html/canvas/WebGLRenderingContextBase.h: * Source/WebCore/page/EventSource.cpp: (WebCore::EventSource::scheduleInitialConnect): (WebCore::EventSource::scheduleReconnect): (WebCore::EventSource::close): * Source/WebCore/page/EventSource.h: * Source/WebCore/xml/XMLHttpRequestProgressEventThrottle.cpp: (WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent): (WebCore::XMLHttpRequestProgressEventThrottle::dispatchThrottledProgressEventTimerFired): * Source/WebCore/xml/XMLHttpRequestProgressEventThrottle.h: Canonical link: https://commits.webkit.org/266715@main
ec8656b
to
6b2ef31
Compare
Committed 266715@main (6b2ef31): https://commits.webkit.org/266715@main Reviewed commits have been landed. Closing PR #16498 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6b2ef31
ec8656b
π wincairoπ§ͺ wpe-wk2π§ͺ gtk-wk2π§ͺ api-gtkπ§ͺ mac-AS-debug-wk2