Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GTK] Some tests in fast/hidpi are crashing in debug builds #16562

Merged

Conversation

obyknovenius
Copy link
Contributor

@obyknovenius obyknovenius commented Aug 10, 2023

2121192

[GTK] Some tests in `fast/hidpi` are crashing in debug builds
https://bugs.webkit.org/show_bug.cgi?id=260021

Reviewed by Miguel Gomez and Carlos Garcia Campos.

These tests are setting custom backing scale factor from JS.
We must re-create the drawing area's backing store when it happens.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp:
(WebKit::DrawingAreaProxyCoordinatedGraphics::incorporateUpdate):

Canonical link: https://commits.webkit.org/266813@main

ce0f9bb

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@obyknovenius obyknovenius self-assigned this Aug 10, 2023
@obyknovenius obyknovenius added the WebKitGTK Bugs related to the Gtk API layer. label Aug 10, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 10, 2023
@obyknovenius obyknovenius added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Aug 11, 2023
https://bugs.webkit.org/show_bug.cgi?id=260021

Reviewed by Miguel Gomez and Carlos Garcia Campos.

These tests are setting custom backing scale factor from JS.
We must re-create the drawing area's backing store when it happens.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp:
(WebKit::DrawingAreaProxyCoordinatedGraphics::incorporateUpdate):

Canonical link: https://commits.webkit.org/266813@main
@webkit-commit-queue
Copy link
Collaborator

Committed 266813@main (2121192): https://commits.webkit.org/266813@main

Reviewed commits have been landed. Closing PR #16562 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 2121192 into WebKit:main Aug 11, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 11, 2023
@obyknovenius obyknovenius deleted the fix/gtk/debug/fast/hidpi branch August 11, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKitGTK Bugs related to the Gtk API layer.
Projects
None yet
6 participants