Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contributors.json: Add myself Frances Cornwall #16585

Merged
merged 1 commit into from
Aug 11, 2023
Merged

contributors.json: Add myself Frances Cornwall #16585

merged 1 commit into from
Aug 11, 2023

Conversation

francescorn
Copy link
Contributor

@francescorn francescorn commented Aug 10, 2023 •
edited by webkit-early-warning-system
Loading

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 10, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 3399f2b)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt   🧪 gtk-wk2
⏳ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2   🧪 api-gtk
  🛠 tv ⏳ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
⏳ 🛠 watch
✅ 🛠 watch-sim

nt1m
nt1m approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@nt1m nt1m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the missing s in contributors.json (in the commit title) and in your github username?

metadata/contributors.json Outdated
"frances_c@cox.net"
],
"expertise" : "Web Inspector",
"github" : "francecorn",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a typo in the github username

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the typo is back :)

@francescorn francescorn changed the title contributor.json: Add myself Frances Cornwall contributors.json: Add myself Frances Cornwall Aug 11, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 11, 2023 •
edited
Loading

EWS run on previous version of this PR (hash e8c5f60)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 webkitpy ⏳ 🧪 ios-wk2-wpt ⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc ✅ 🧪 api-ios   🧪 mac-wk2 ⏳ 🧪 api-gtk
⏳ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2
⏳ 🛠 tv-sim
⏳ 🛠 watch
❌ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@nt1m nt1m added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 11, 2023
@webkit-commit-queue
Copy link
Collaborator

This change contains multiple commits which are not squashed together, blocking PR #16585. Please squash the commits to land.

@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Aug 11, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 11, 2023 •
edited
Loading

EWS run on previous version of this PR (hash a44830e)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2 ⏳ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 webkitpy ⏳ 🧪 ios-wk2-wpt ⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc ⏳ 🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
⏳ 🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m removed the merging-blocked Applied to prevent a change from being merged label Aug 11, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 11, 2023 •
edited
Loading

EWS run on current version of this PR (hash e4d39e0)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 webkitpy   🧪 ios-wk2-wpt   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
  🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@nt1m nt1m added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 11, 2023
@francescorn @nt1m
contributors.json: Add myself Frances Cornwall
b7f03d4 
https://bugs.webkit.org/show_bug.cgi?id=260049

Reviewed by Tim Nguyen.

Add myself, Frances Cornwall, to the webkit contributors list.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/266800@main
@webkit-commit-queue
Copy link
Collaborator

Committed 266800@main (b7f03d4): https://commits.webkit.org/266800@main

Reviewed commits have been landed. Closing PR #16585 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b7f03d4 into WebKit:main Aug 11, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nt1m nt1m nt1m approved these changes

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@francescorn @webkit-early-warning-system @webkit-commit-queue @nt1m