Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SVGAnimateElement respect javascriptMarkupEnabled #1665

Merged
merged 0 commits into from Jun 22, 2022
Merged

Make SVGAnimateElement respect javascriptMarkupEnabled #1665

merged 0 commits into from Jun 22, 2022

Conversation

nt1m
Copy link
Member

@nt1m nt1m commented Jun 21, 2022 •
edited by webkit-commit-queue

431f4db

Make SVGAnimateElement respect javascriptMarkupEnabled
https://bugs.webkit.org/show_bug.cgi?id=241820
<rdar://92834618 >

Reviewed by Said Abou-Hallawa.

from/to/values attributes should be stripped in presence of javascript URLs with the pref on.

* Source/WebCore/dom/Element.cpp:
(WebCore::Element::attributeContainsJavascriptURL const):
(WebCore::Element::stripScriptingAttributes const):
(WebCore::Element::isJavaScriptURLAttribute const): Deleted.
* Source/WebCore/dom/Element.h:
* Source/WebCore/editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::removeContentsWithSideEffects):
* Source/WebCore/editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendStartTag):
* Source/WebCore/svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::attributeContainsJavascriptURL const):
* Source/WebCore/svg/SVGAnimationElement.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
(TEST):

Canonical link: https://commits.webkit.org/251752@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@nt1m nt1m requested a review from JonWBedard as a code owner June 21, 2022 23:07
@nt1m nt1m self-assigned this Jun 21, 2022
@nt1m nt1m added SVG For bugs in the SVG implementation. WebKit Nightly Build labels Jun 21, 2022
@nt1m nt1m requested a review from shallawa June 21, 2022 23:08
@nt1m nt1m force-pushed the eng/svg-animate-script branch 2 times, most recently from cd0c5c0 to 571b569 Compare June 22, 2022 01:12
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label Jun 22, 2022
@nt1m nt1m removed merging-blocked Applied to prevent a change from being merged SVG For bugs in the SVG implementation. WebKit Nightly Build labels Jun 22, 2022
@nt1m nt1m added SVG For bugs in the SVG implementation. WebKit Nightly Build labels Jun 22, 2022
@nt1m nt1m added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 22, 2022
@webkit-commit-queue webkit-commit-queue merged commit 431f4db into WebKit:main Jun 22, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed r295747 (251752@main): https://commits.webkit.org/251752@main

Reviewed commits have been landed. Closing PR #1665 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 22, 2022
@nt1m nt1m deleted the eng/svg-animate-script branch June 22, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shallawa shallawa shallawa approved these changes

@JonWBedard JonWBedard Awaiting requested review from JonWBedard

Assignees

@nt1m nt1m

Labels
SVG For bugs in the SVG implementation.
Projects
None yet
Milestone
No milestone
4 participants
@nt1m @webkit-commit-queue @shallawa @webkit-early-warning-system