Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for usesWebKitBehavior at runtime. #16685

Merged

Conversation

mattwoodrow
Copy link
Contributor

@mattwoodrow mattwoodrow commented Aug 14, 2023

0330e63

Check for usesWebKitBehavior at runtime.
https://bugs.webkit.org/show_bug.cgi?id=260178
<rdar://113874964>

Reviewed by Dan Glastonbury.

We should be able to enable 3d transform interop at runtime, if the required property is available.

* LayoutTests/TestExpectations:
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h:
* Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(WebCore::PlatformCALayerCocoa::commonInit):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::createLayer):

Canonical link: https://commits.webkit.org/266974@main

ce065dc

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@mattwoodrow mattwoodrow self-assigned this Aug 14, 2023
@mattwoodrow mattwoodrow added the Layout and Rendering For bugs with layout and rendering of Web pages. label Aug 14, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 14, 2023
@mattwoodrow mattwoodrow removed the merging-blocked Applied to prevent a change from being merged label Aug 14, 2023
@mattwoodrow mattwoodrow force-pushed the eng/runtime-3d-transform-check branch from 32a6815 to 9dfd417 Compare August 14, 2023 22:24
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 15, 2023
@mattwoodrow mattwoodrow removed the merging-blocked Applied to prevent a change from being merged label Aug 15, 2023
@mattwoodrow mattwoodrow force-pushed the eng/runtime-3d-transform-check branch from 9dfd417 to 4baaf16 Compare August 15, 2023 23:19
@mattwoodrow mattwoodrow force-pushed the eng/runtime-3d-transform-check branch from 4baaf16 to ce065dc Compare August 16, 2023 01:17
@mattwoodrow mattwoodrow requested a review from smfr August 16, 2023 06:23
@mattwoodrow mattwoodrow added the merge-queue Applied to send a pull request to merge-queue label Aug 17, 2023
https://bugs.webkit.org/show_bug.cgi?id=260178
<rdar://113874964>

Reviewed by Dan Glastonbury.

We should be able to enable 3d transform interop at runtime, if the required property is available.

* LayoutTests/TestExpectations:
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h:
* Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(WebCore::PlatformCALayerCocoa::commonInit):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::createLayer):

Canonical link: https://commits.webkit.org/266974@main
@webkit-commit-queue
Copy link
Collaborator

Committed 266974@main (0330e63): https://commits.webkit.org/266974@main

Reviewed commits have been landed. Closing PR #16685 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0330e63 into WebKit:main Aug 17, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Layout and Rendering For bugs with layout and rendering of Web pages.
Projects
None yet
6 participants