[WinCairo] Search inputs do not show icons

[donny-dont]

810eb19

[WinCairo] Search inputs do not show icons
https://bugs.webkit.org/show_bug.cgi?id=188175

Reviewed by NOBODY (OOPS!).

Move Windows resources from WebKitLegacy into WebCore so it can be shared with WebKit.

* Source/WebCore/PlatformWin.cmake:
* Source/WebCore/platform/graphics/win/ImageWin.cpp:
* Source/WebCore/platform/win/WebCore.resources/WebCore.rc: Copied from Source/WebKitLegacy/win/WebKit.resources/WebKit.rc.
* Source/WebCore/platform/win/WebCore.resources/deleteButton.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/deleteButton.png.
* Source/WebCore/platform/win/WebCore.resources/deleteButtonPressed.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/deleteButtonPressed.png.
* Source/WebCore/platform/win/WebCore.resources/fsVideoAudioVolumeHigh.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/fsVideoAudioVolumeHigh.png.
* Source/WebCore/platform/win/WebCore.resources/fsVideoAudioVolumeLow.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/fsVideoAudioVolumeLow.png.
* Source/WebCore/platform/win/WebCore.resources/fsVideoExitFullscreen.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/fsVideoExitFullscreen.png.
* Source/WebCore/platform/win/WebCore.resources/fsVideoPause.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/fsVideoPause.png.
* Source/WebCore/platform/win/WebCore.resources/fsVideoPlay.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/fsVideoPlay.png.
* Source/WebCore/platform/win/WebCore.resources/missingImage.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/missingImage.png.
* Source/WebCore/platform/win/WebCore.resources/nullplugin.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/nullplugin.png.
* Source/WebCore/platform/win/WebCore.resources/panEastCursor.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/panEastCursor.png.
* Source/WebCore/platform/win/WebCore.resources/panIcon.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/panIcon.png.
* Source/WebCore/platform/win/WebCore.resources/panNorthCursor.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/panNorthCursor.png.
* Source/WebCore/platform/win/WebCore.resources/panNorthEastCursor.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/panNorthEastCursor.png.
* Source/WebCore/platform/win/WebCore.resources/panNorthWestCursor.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/panNorthWestCursor.png.
* Source/WebCore/platform/win/WebCore.resources/panSouthCursor.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/panSouthCursor.png.
* Source/WebCore/platform/win/WebCore.resources/panSouthEastCursor.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/panSouthEastCursor.png.
* Source/WebCore/platform/win/WebCore.resources/panSouthWestCursor.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/panSouthWestCursor.png.
* Source/WebCore/platform/win/WebCore.resources/panWestCursor.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/panWestCursor.png.
* Source/WebCore/platform/win/WebCore.resources/searchCancel.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/searchCancel.png.
* Source/WebCore/platform/win/WebCore.resources/searchCancelPressed.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/searchCancelPressed.png.
* Source/WebCore/platform/win/WebCore.resources/searchMagnifier.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/searchMagnifier.png.
* Source/WebCore/platform/win/WebCore.resources/searchMagnifierResults.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/searchMagnifierResults.png.
* Source/WebCore/platform/win/WebCore.resources/textAreaResizeCorner.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/textAreaResizeCorner.png.
* Source/WebCore/platform/win/WebCore.resources/verticalTextCursor.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/verticalTextCursor.png.
* Source/WebCore/platform/win/WebCore.resources/zoomInCursor.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/zoomInCursor.png.
* Source/WebCore/platform/win/WebCore.resources/zoomOutCursor.png: Renamed from Source/WebKitLegacy/win/WebKit.resources/zoomOutCursor.png.
* Source/WebCore/platform/win/resource.h: Copied from Source/WebKitLegacy/win/resource.h.
* Source/WebKitLegacy/win/WebKit.resources/WebKit.rc:
* Source/WebKitLegacy/win/WebKitDLL.cpp:
* Source/WebKitLegacy/win/resource.h:
* Tools/TestWebKitAPI/PlatformWin.cmake:
* Tools/TestWebKitAPI/win/TestWebCoreStubs.cpp: Removed.

810eb19

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

[donny-dont]

Rebase of @foopoiuyt ’s patch at https://bugs.webkit.org/show_bug.cgi?id=188175#c7

[fujii]

Win EWS failures seems to be true-positive. WebCore module is not a DLL. We should copy the resource images to WK2, or make WebCore module a DLL.

editing/execCommand/insertImage.html [ Failure ]
fast/images/inline-image-box-with-no-alt-should-collapse-no-quirks.html [ Failure ]
fast/images/inline-image-box-with-no-alt-should-collapse-quirks.html [ Failure ]

[donny-dont]

Yea the AppleWin failure is legit @fujii . I just want to try a couple things to see if I can get this working without just copying resources.

[donny-dont]

So my working theory is that WebCore_LIBRARY_TYPE being STATIC is causing the issue. A local WinCairo is able to load the resource in a WebKit and WebKitLegacy window within MiniBrowser and WebCore_LIBRARY_TYPE is OBJECT for them.

So if this works I think the way to go is to make a WebCoreResources library whose type is OBJECT and just contains the .rc file for its source. Not sure how this would work with the internal build but I think this would be the way.

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 4e5eeea)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	💥 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
⏳ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 24412fb)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 3ad31f8)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
⏳ 🧪 style	⏳ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 wincairo
⏳ 🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	🛠 gtk
⏳ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	🧪 gtk-wk2
	⏳ 🧪 api-ios	⏳ 🧪 mac-wk1	🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	⏳ 🧪 mac-wk2	⏳ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	⏳ 🧪 mac-wk2-stress	⏳ 🛠 jsc-mips
	⏳ 🛠 watch-sim		⏳ 🧪 jsc-mips-tests

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 6862096)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	⏳ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 wincairo
⏳ 🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	🛠 gtk
⏳ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	🧪 gtk-wk2
	⏳ 🧪 api-ios	⏳ 🧪 mac-wk1	🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	⏳ 🧪 mac-wk2	⏳ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	⏳ 🧪 mac-wk2-stress	⏳ 🛠 jsc-mips
	⏳ 🛠 watch-sim		⏳ 🧪 jsc-mips-tests

[webkit-early-warning-system]

EWS run on current version of this PR (hash 810eb19)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

[brentfulgham]

I moved the resources from WebKitLegacy to WebCore in PR #10162.

[donny-dont]

No longer relevant