[Glib] Initialize WebProcessExtensions in API tests on demand

[obyknovenius]

f7d2305

[Glib] Initialize `WebProcessExtension`s in API tests on demand
https://bugs.webkit.org/show_bug.cgi?id=260382

Reviewed by Carlos Garcia Campos and Michael Catanzaro.

Currently, `WebProcessExtension`s are initialized for each API test.
It's not only unnecessary but can lead to flakiness.

This patch requires API tests using extensions to explicitly state this
by setting `Test::shouldInitializeWebProcessExtensions` to `true`.

* Tools/TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
(beforeAll):
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
(beforeAll):
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
(beforeAll):
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
(beforeAll):
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
(beforeAll):
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
(beforeAll):
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
(beforeAll):
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
(beforeAll):
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebProcessExtensions.cpp:
(beforeAll):
* Tools/TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
(beforeAll):
* Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
(beforeAll):
* Tools/TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
(beforeAll):
* Tools/TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
(beforeAll):
* Tools/TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
(beforeAll):
* Tools/TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
(beforeAll):
* Tools/TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
* Tools/TestWebKitAPI/glib/WebKitGLib/TestMain.h:
(Test::Test):

Canonical link: https://commits.webkit.org/267125@main

30eaf31

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash a57507b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	❌ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[mcatanzaro]

I agree this change is fine, but I wish we understood how it could cause flakiness. It certainly shouldn't.

[obyknovenius]

I can give an example. When a test finishes fast and we're stopping the DBus server, an extension can still be trying to connect to it and we're getting a failing assertion here:

WebKit/Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessExtensionTest.cpp

Line 702 in 971943d

g_assert(G_IS_DBUS_CONNECTION(connection));

I faced it in WebKitGTK/TestWebKitWebContext test but only in debug build with an error that looked totally unrelated.

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 7f9058a)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	❌ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash 30eaf31)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-commit-queue]

Committed 267125@main (f7d2305): https://commits.webkit.org/267125@main

Reviewed commits have been landed. Closing PR #16828 and removing active labels.