-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the 'required' flag in the JsonWebKey's 'kty' field #16869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EWS run on previous version of this PR (hash 15e4f36) |
javifernandez
added
the
WebCore Misc.
For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
label
Aug 19, 2023
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Aug 20, 2023
The affected tests needs an updated baseline, beyond that @youennf should weigh in. |
javifernandez
removed
the
merging-blocked
Applied to prevent a change from being merged
label
Aug 21, 2023
javifernandez
force-pushed
the
bug-260430
branch
from
August 21, 2023 13:29
15e4f36
to
f215874
Compare
EWS run on current version of this PR (hash f215874) |
youennf
approved these changes
Aug 21, 2023
javifernandez
added
the
merge-queue
Applied to send a pull request to merge-queue
label
Aug 22, 2023
https://bugs.webkit.org/show_bug.cgi?id=260430 Reviewed by Youenn Fablet. Marking the 'kty' field as required causes that we throw a TypeError exception during the IDL-JS type mapping phase. However, the specs of the different algorithms state that we should throw a DataError instead. By removing the 'required' flag of the mentioned field we allow the implementation of each algorithm to deal with the issue, detecting either the lack of that mandatory field or an incorrect value for the specific algorithm. It's worth mentioning that the current implementation of the algorithms already performs the required checks, throwing a DataError exception as the spec states. Hence, this change just avoids the early checks and let the algorithms execute their specific logic. * LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_Ed25519.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_Ed25519.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_Ed448.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_Ed448.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_X25519.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_X25519.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_X448.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_X448.https.any.worker-expected.txt: * Source/WebCore/crypto/JsonWebKey.idl: Canonical link: https://commits.webkit.org/267131@main
webkit-commit-queue
force-pushed
the
bug-260430
branch
from
August 22, 2023 13:57
f215874
to
58f6c8c
Compare
Committed 267131@main (58f6c8c): https://commits.webkit.org/267131@main Reviewed commits have been landed. Closing PR #16869 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
WebCore Misc.
For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
58f6c8c
f215874