Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go back to using the default bounds for password and search fields' InteractionRegions #16886

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

etiennesegonzac
Copy link
Contributor

@etiennesegonzac etiennesegonzac commented Aug 21, 2023

c8e2963

Go back to using the default bounds for password and search fields' InteractionRegions
https://bugs.webkit.org/show_bug.cgi?id=260466
<rdar://112718594>

Reviewed by Tim Horton.

Remove the old workaround and add a new test so we can do more surgical
tweaks in the future if needed.

* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::interactionRegionForRenderedRegion):
Remove the bounds extension for HTMLInputElements.

* LayoutTests/interaction-region/text-input-expected.txt: Added.
* LayoutTests/interaction-region/text-input.html: Added.
Add new test.
* LayoutTests/interaction-region/interaction-layers-culling-expected.txt:
* LayoutTests/interaction-region/layer-tree-expected.txt:
Test update, unrelated.

Canonical link: https://commits.webkit.org/267230@main

60161f3

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@etiennesegonzac etiennesegonzac self-assigned this Aug 21, 2023
@etiennesegonzac etiennesegonzac added the Layout and Rendering For bugs with layout and rendering of Web pages. label Aug 21, 2023
@etiennesegonzac etiennesegonzac added the merge-queue Applied to send a pull request to merge-queue label Aug 24, 2023
…nteractionRegions

https://bugs.webkit.org/show_bug.cgi?id=260466
<rdar://112718594>

Reviewed by Tim Horton.

Remove the old workaround and add a new test so we can do more surgical
tweaks in the future if needed.

* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::interactionRegionForRenderedRegion):
Remove the bounds extension for HTMLInputElements.

* LayoutTests/interaction-region/text-input-expected.txt: Added.
* LayoutTests/interaction-region/text-input.html: Added.
Add new test.
* LayoutTests/interaction-region/interaction-layers-culling-expected.txt:
* LayoutTests/interaction-region/layer-tree-expected.txt:
Test update, unrelated.

Canonical link: https://commits.webkit.org/267230@main
@webkit-commit-queue
Copy link
Collaborator

Committed 267230@main (c8e2963): https://commits.webkit.org/267230@main

Reviewed commits have been landed. Closing PR #16886 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 24, 2023
@webkit-commit-queue webkit-commit-queue merged commit c8e2963 into WebKit:main Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Layout and Rendering For bugs with layout and rendering of Web pages.
Projects
None yet
4 participants