Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-place interpreter: fix clobbered register in call and reduce memory usage for if and br #16890

Merged
merged 1 commit into from
Aug 22, 2023
Merged

In-place interpreter: fix clobbered register in call and reduce memory usage for if and br #16890

merged 1 commit into from
Aug 22, 2023

Conversation

danlliu
Copy link
Contributor

@danlliu danlliu commented Aug 21, 2023 •
edited by webkit-early-warning-system

fcf3ca8

In-place interpreter: fix clobbered register in call and reduce memory usage for if and br
https://bugs.webkit.org/show_bug.cgi?id=260471
rdar://114218539

Reviewed by Yusuke Suzuki.

Updated `call` instruction to save caller save registers around the operation call.
Reduce memory usage for if and br by 3B by saving the size of the instruction instead of the next PC.

* Source/JavaScriptCore/llint/InPlaceInterpreter.asm:
* Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp:
(JSC::Wasm::IPIntGenerator::addIf):
(JSC::Wasm::IPIntGenerator::addBranch):
(JSC::Wasm::IPIntGenerator::addSwitch):

Canonical link: https://commits.webkit.org/267142@main

a9fbe41

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ❌ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ❌ 🧪 jsc-mips-tests

@danlliu danlliu requested a review from a team as a code owner August 21, 2023 16:58
@danlliu danlliu self-assigned this Aug 21, 2023
@danlliu danlliu added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Aug 21, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 8a9ff9f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
❌ 🛠 🧪 merge ✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

Constellation
Constellation approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@danlliu danlliu added the merge-queue Applied to send a pull request to merge-queue label Aug 21, 2023
@webkit-commit-queue
Copy link
Collaborator

Commit message contains (OOPS!), blocking PR #16890

@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Aug 21, 2023
@danlliu danlliu removed the merging-blocked Applied to prevent a change from being merged label Aug 21, 2023
@danlliu danlliu force-pushed the eng/In-place-interpreter-fix-clobbered-register-in-call-and-reduce-memory-usage-for-if-and-br branch from 8a9ff9f to a9fbe41 Compare August 21, 2023 21:40
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash a9fbe41)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ❌ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ❌ 🧪 jsc-mips-tests

@danlliu danlliu added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 22, 2023
@danlliu
In-place interpreter: fix clobbered register in call and reduce memor…
fcf3ca8 
…y usage for if and br

https://bugs.webkit.org/show_bug.cgi?id=260471
rdar://114218539

Reviewed by Yusuke Suzuki.

Updated `call` instruction to save caller save registers around the operation call.
Reduce memory usage for if and br by 3B by saving the size of the instruction instead of the next PC.

* Source/JavaScriptCore/llint/InPlaceInterpreter.asm:
* Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp:
(JSC::Wasm::IPIntGenerator::addIf):
(JSC::Wasm::IPIntGenerator::addBranch):
(JSC::Wasm::IPIntGenerator::addSwitch):

Canonical link: https://commits.webkit.org/267142@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/In-place-interpreter-fix-clobbered-register-in-call-and-reduce-memory-usage-for-if-and-br branch from a9fbe41 to fcf3ca8 Compare August 22, 2023 18:08
@webkit-commit-queue
Copy link
Collaborator

Committed 267142@main (fcf3ca8): https://commits.webkit.org/267142@main

Reviewed commits have been landed. Closing PR #16890 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit fcf3ca8 into WebKit:main Aug 22, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Constellation Constellation Constellation approved these changes

Assignees

@danlliu danlliu

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
4 participants
@danlliu @webkit-early-warning-system @webkit-commit-queue @Constellation