Update lldbWebKitTester's CLANG_DEBUG_INFORMATION_LEVEL workaround for workspace builds #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emw-apple
added
Tools / Tests
| self.setCommand(self.command + ['DEBUG_INFORMATION_FORMAT=dwarf-with-dsym']) | ||
| self.setCommand(self.command + ['CLANG_DEBUG_INFORMATION_LEVEL=line-tables-only']) | ||
| self.setCommand(self.command + ['CLANG_DEBUG_INFORMATION_LEVEL=$(WK_OVERRIDE_DEBUG_INFORMATION_LEVEL:default=line-tables-only)']) |
There was a problem hiding this comment.
How does this work with CMake?
There was a problem hiding this comment.
This code is Xcode-only. Just outside the diff context is an if platform in ('mac', 'ios', 'tvos', 'watchos') statement.
aproskuryakov
approved these changes
Jun 23, 2022
…r workspace builds https://bugs.webkit.org/show_bug.cgi?id=241863 Reviewed by Alexey Proskuryakov. When building lldbWebKitTester, we used to transparently filter out the CLANG_DEBUG_INFORMATION_LEVEL setting that buildbot passes. Now that builds are a single xcodebuild invocation, we cannot do that. Introduce a WK_OVERRIDE_DEBUG_INFORMATION_LEVEL setting, which lldbWebKitTester sets to its required debug info level. Change buildbot's overrides to prefer this setting over `line-tables-only`. * Tools/CISupport/build-webkit-org/steps.py: (CompileWebKit.start): * Tools/CISupport/ews-build/steps.py: (CompileWebKit.start): * Tools/Scripts/webkitdirs.pm: (buildXCodeProject): * Tools/lldb/lldbWebKitTester/Configurations/lldbWebKitTester.xcconfig: Canonical link: https://commits.webkit.org/251808@main
webkit-early-warning-system
force-pushed
the
eng/fix-workspace-build-lldbWebKitTester-debug-info
branch
from
4521e41
to
1b9d289
Compare
|
Committed 251808@main (1b9d289): https://commits.webkit.org/251808@main Reviewed commits have been landed. Closing PR #1692 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
yury-s
pushed a commit
to yury-s/WebKit
that referenced
this pull request
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1b9d289