Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heap identifier macros to WebCore/animation #16944

Conversation

rreno
Copy link
Member

@rreno rreno commented Aug 22, 2023

c923b30

Add heap identifier macros to WebCore/animation
https://bugs.webkit.org/show_bug.cgi?id=260547
rdar://114281522

Reviewed by Brent Fulgham.

Replace WTF_MAKE_FAST_ALLOCATED with
WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER for more fine-grained
diagnostics when building with MallocHeapBreakdown enabled.

* Source/WebCore/animation/AcceleratedTimeline.cpp:
* Source/WebCore/animation/AcceleratedTimeline.h:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
* Source/WebCore/animation/DocumentTimelinesController.cpp:
* Source/WebCore/animation/DocumentTimelinesController.h:
* Source/WebCore/animation/ElementAnimationRareData.cpp:
* Source/WebCore/animation/ElementAnimationRareData.h:
* Source/WebCore/animation/FrameRateAligner.cpp:
* Source/WebCore/animation/FrameRateAligner.h:
* Source/WebCore/animation/KeyframeEffectStack.cpp:
* Source/WebCore/animation/KeyframeEffectStack.h:

Canonical link: https://commits.webkit.org/267159@main

beed88a

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv   πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@rreno rreno requested a review from graouts as a code owner August 22, 2023 21:25
@rreno rreno self-assigned this Aug 22, 2023
@rreno rreno added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Aug 22, 2023
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. r=me

@rreno rreno added the merge-queue Applied to send a pull request to merge-queue label Aug 22, 2023
https://bugs.webkit.org/show_bug.cgi?id=260547
rdar://114281522

Reviewed by Brent Fulgham.

Replace WTF_MAKE_FAST_ALLOCATED with
WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER for more fine-grained
diagnostics when building with MallocHeapBreakdown enabled.

* Source/WebCore/animation/AcceleratedTimeline.cpp:
* Source/WebCore/animation/AcceleratedTimeline.h:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
* Source/WebCore/animation/DocumentTimelinesController.cpp:
* Source/WebCore/animation/DocumentTimelinesController.h:
* Source/WebCore/animation/ElementAnimationRareData.cpp:
* Source/WebCore/animation/ElementAnimationRareData.h:
* Source/WebCore/animation/FrameRateAligner.cpp:
* Source/WebCore/animation/FrameRateAligner.h:
* Source/WebCore/animation/KeyframeEffectStack.cpp:
* Source/WebCore/animation/KeyframeEffectStack.h:

Canonical link: https://commits.webkit.org/267159@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Add-heap-identifier-macros-to-WebCore-animation branch from beed88a to c923b30 Compare August 22, 2023 23:24
@webkit-commit-queue
Copy link
Collaborator

Committed 267159@main (c923b30): https://commits.webkit.org/267159@main

Reviewed commits have been landed. Closing PR #16944 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c923b30 into WebKit:main Aug 22, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
4 participants