Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS 17] AdvancedPrivacyProtections.AddNoiseToWebAudioAPIs fails after 265168@main #16985

Merged
merged 1 commit into from
Aug 23, 2023
Merged

[iOS 17] AdvancedPrivacyProtections.AddNoiseToWebAudioAPIs fails after 265168@main #16985

merged 1 commit into from
Aug 23, 2023

Conversation

whsieh
Copy link
Member

@whsieh whsieh commented Aug 23, 2023 •
edited by webkit-early-warning-system
Loading

32965cb

[iOS 17] AdvancedPrivacyProtections.AddNoiseToWebAudioAPIs fails after 265168@main
https://bugs.webkit.org/show_bug.cgi?id=260618

Reviewed by Tim Horton.

After the changes in 265168@main, this API test fails because the `testOscillatorCompressorWorklet`
step requires user activation after triggering the initial async function call in order to begin
producing "sound" (really, an inaudible audio signal), which the test then waits for; avoid this
issue altogether by using `-[WKWebViewConfiguration setMediaTypesRequiringUserActionForPlayback:]`
to allow web audio to play back regardless of user activation.

* Tools/TestWebKitAPI/Tests/WebKit/AdvancedPrivacyProtections.mm:

Canonical link: https://commits.webkit.org/267200@main

7bd9900

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@whsieh whsieh self-assigned this Aug 23, 2023
@whsieh whsieh added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Aug 23, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 23, 2023 •
edited
Loading

EWS run on current version of this PR (hash 7bd9900)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@whsieh whsieh added the merge-queue Applied to send a pull request to merge-queue label Aug 23, 2023
@whsieh
Copy link
Member Author

whsieh commented Aug 23, 2023

Thanks for the review!

@whsieh
[iOS 17] AdvancedPrivacyProtections.AddNoiseToWebAudioAPIs fails afte…
32965cb 
…r 265168@main

https://bugs.webkit.org/show_bug.cgi?id=260618

Reviewed by Tim Horton.

After the changes in 265168@main, this API test fails because the `testOscillatorCompressorWorklet`
step requires user activation after triggering the initial async function call in order to begin
producing "sound" (really, an inaudible audio signal), which the test then waits for; avoid this
issue altogether by using `-[WKWebViewConfiguration setMediaTypesRequiringUserActionForPlayback:]`
to allow web audio to play back regardless of user activation.

* Tools/TestWebKitAPI/Tests/WebKit/AdvancedPrivacyProtections.mm:

Canonical link: https://commits.webkit.org/267200@main
@webkit-commit-queue
Copy link
Collaborator

Committed 267200@main (32965cb): https://commits.webkit.org/267200@main

Reviewed commits have been landed. Closing PR #16985 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 32965cb into WebKit:main Aug 23, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 23, 2023
@whsieh whsieh deleted the eng/260618 branch August 23, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hortont424 hortont424 hortont424 approved these changes

@pxlcoder pxlcoder Awaiting requested review from pxlcoder

@rr-codes rr-codes Awaiting requested review from rr-codes

@charliewolfe charliewolfe Awaiting requested review from charliewolfe

@sysrqb sysrqb Awaiting requested review from sysrqb

Assignees

@whsieh whsieh

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
4 participants
@whsieh @webkit-early-warning-system @webkit-commit-queue @hortont424