Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid double hash map look up in SVGElement::updateRelativeLengthsInformation() #17134

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Avoid double hash map look up in SVGElement::updateRelativeLengthsInformation() #17134

merged 1 commit into from
Aug 28, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Aug 28, 2023 •
edited by webkit-early-warning-system
Loading

29181a1

Avoid double hash map look up in SVGElement::updateRelativeLengthsInformation()
https://bugs.webkit.org/show_bug.cgi?id=260803

Reviewed by Ryosuke Niwa.

Avoid double hash map look up in SVGElement::updateRelativeLengthsInformation()
and do minor code cleanup.

* Source/WebCore/svg/SVGElement.cpp:
(WebCore::SVGElement::updateRelativeLengthsInformation):

Canonical link: https://commits.webkit.org/267358@main

17d8b6f

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
  🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Aug 28, 2023
@cdumez cdumez added the SVG For bugs in the SVG implementation. label Aug 28, 2023
@cdumez cdumez requested review from rniwa and shallawa August 28, 2023 17:43
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 28, 2023 •
edited
Loading

EWS run on current version of this PR (hash 17d8b6f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
  🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

rniwa
rniwa approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@rniwa rniwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also see #16068

@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Aug 28, 2023
@cdumez
Avoid double hash map look up in SVGElement::updateRelativeLengthsInf…
29181a1 
…ormation()

https://bugs.webkit.org/show_bug.cgi?id=260803

Reviewed by Ryosuke Niwa.

Avoid double hash map look up in SVGElement::updateRelativeLengthsInformation()
and do minor code cleanup.

* Source/WebCore/svg/SVGElement.cpp:
(WebCore::SVGElement::updateRelativeLengthsInformation):

Canonical link: https://commits.webkit.org/267358@main
@webkit-commit-queue
Copy link
Collaborator

Committed 267358@main (29181a1): https://commits.webkit.org/267358@main

Reviewed commits have been landed. Closing PR #17134 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 29181a1 into WebKit:main Aug 28, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rniwa rniwa rniwa approved these changes

@shallawa shallawa Awaiting requested review from shallawa

Assignees

@cdumez cdumez

Labels
SVG For bugs in the SVG implementation.
Projects
None yet
Milestone
No milestone
4 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @rniwa