Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SharedWorker referrer policy should default to its context referrer policy if none is provided in its script http response #17183

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Aug 29, 2023

d1c532b

SharedWorker referrer policy should default to its context referrer policy if none is provided in its script http response
https://bugs.webkit.org/show_bug.cgi?id=260858
rdar://114625126

Reviewed by Chris Dumez.

As per https://github.com/w3c/webappsec-referrer-policy, we should default to the context initiating the first load as of referrer policy.
Implement this for SharedWorker in SharedWorkerScriptLoader.

* LayoutTests/imported/w3c/web-platform-tests/workers/modules/shared-worker-import-referrer-expected.txt:
* Source/WebCore/workers/shared/SharedWorkerScriptLoader.cpp:
(WebCore::SharedWorkerScriptLoader::notifyFinished):

Canonical link: https://commits.webkit.org/267405@main

c50873f

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 ❌ πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@youennf youennf requested a review from cdumez as a code owner August 29, 2023 13:56
@youennf youennf self-assigned this Aug 29, 2023
@youennf youennf added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Aug 29, 2023
Copy link
Contributor

@cdumez cdumez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youennf youennf added the merge-queue Applied to send a pull request to merge-queue label Aug 29, 2023
…olicy if none is provided in its script http response

https://bugs.webkit.org/show_bug.cgi?id=260858
rdar://114625126

Reviewed by Chris Dumez.

As per https://github.com/w3c/webappsec-referrer-policy, we should default to the context initiating the first load as of referrer policy.
Implement this for SharedWorker in SharedWorkerScriptLoader.

* LayoutTests/imported/w3c/web-platform-tests/workers/modules/shared-worker-import-referrer-expected.txt:
* Source/WebCore/workers/shared/SharedWorkerScriptLoader.cpp:
(WebCore::SharedWorkerScriptLoader::notifyFinished):

Canonical link: https://commits.webkit.org/267405@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/SharedWorker-referrer-policy-should-default-to-its-context-referrer-policy-if-none-is-provided-in-its-script-http-response branch from c50873f to d1c532b Compare August 29, 2023 15:32
@webkit-commit-queue
Copy link
Collaborator

Committed 267405@main (d1c532b): https://commits.webkit.org/267405@main

Reviewed commits have been landed. Closing PR #17183 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit d1c532b into WebKit:main Aug 29, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
4 participants