Convert TrailingZerosTruncatingPolicy into an enum class #17186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
webkit-ews-buildbot
added
the
merging-blocked
annevk
added
skip-ews
annevk
force-pushed
the
eng/Convert-TrailingZerosTruncatingPolicy-into-an-enum-class
branch
from
2828448
to
c563ce3
Compare
|
EWS run on current version of this PR (hash c563ce3) |
nt1m
approved these changes
Aug 30, 2023
https://bugs.webkit.org/show_bug.cgi?id=260863 rdar://114628958 Reviewed by Tim Nguyen. * Source/JavaScriptCore/runtime/NumberPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/WTF/wtf/text/StringConcatenateNumbers.h: (WTF::FormattedNumber::fixedPrecision): * Source/WTF/wtf/text/WTFString.cpp: (WTF::String::numberToStringFixedPrecision): * Source/WTF/wtf/text/WTFString.h: * Source/WebCore/accessibility/AccessibilityObjectInterface.h: (WebCore::AXCoreObject::value): * Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm: (WebCore::ResourceUsageOverlay::platformDraw): * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: (TestWebKitAPI::TEST): * Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp: (WTR::attributesOfElement): Canonical link: https://commits.webkit.org/267447@main
mdubet
approved these changes
Aug 30, 2023
webkit-commit-queue
force-pushed
the
eng/Convert-TrailingZerosTruncatingPolicy-into-an-enum-class
branch
from
c563ce3
to
137065a
Compare
|
Committed 267447@main (137065a): https://commits.webkit.org/267447@main Reviewed commits have been landed. Closing PR #17186 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
annevk
deleted the
eng/Convert-TrailingZerosTruncatingPolicy-into-an-enum-class
branch
darinadler
reviewed
Sep 1, 2023
| @@ -573,7 +573,6 @@ inline String operator"" _str(const UChar* characters, size_t length) | |||
|
|
|||
| } // namespace WTF | |||
|
|
|||
| using WTF::KeepTrailingZeros; | |||
There was a problem hiding this comment.
WTF design has been to use these using statements rather than WTF:: prefixes at site of use. I know this is unconventional, but it’s the pattern we use in most cases across the library. To do that we would have using WTF::TrailingZerosPolicy here and fewer (maybe no) WTF:: prefixes elsewhere.
I’d be open to changing the WTF approach, and if we’d agreed that we’d not do it for anything new that would be OK with me.
But if I was making this change I would have stayed consistent with the approach and done the above.
There was a problem hiding this comment.
Fair! Created #17375.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
137065a
c563ce3
🧪 jsc-armv7-tests