Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSC] Set up wasm stack |this| first #1719

Merged
merged 0 commits into from Jun 23, 2022
Merged

[JSC] Set up wasm stack |this| first #1719

merged 0 commits into from Jun 23, 2022

Conversation

Constellation
Copy link
Member

@Constellation Constellation commented Jun 23, 2022 •
edited by webkit-commit-queue

e49129f

[JSC] Set up wasm stack |this| first
https://bugs.webkit.org/show_bug.cgi?id=241907
rdar://problem/94397072

Reviewed by Mark Lam.

We should set up the stack's |thisValue| first.

* Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp:
(JSC::Wasm::AirIRGenerator::AirIRGenerator):

Canonical link: https://commits.webkit.org/251775@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@Constellation Constellation requested a review from a team as a code owner June 23, 2022 07:42
@Constellation Constellation self-assigned this Jun 23, 2022
@Constellation Constellation added JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. WebKit Nightly Build unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Jun 23, 2022
@webkit-commit-queue webkit-commit-queue merged commit e49129f into WebKit:main Jun 23, 2022
@Constellation Constellation deleted the eng/JSC-Set-up-wasm-stack-this-first branch June 23, 2022 07:46
@webkit-commit-queue
Copy link
Collaborator

Committed r295770 (251775@main): https://commits.webkit.org/251775@main

Reviewed commits have been landed. Closing PR #1719 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Constellation Constellation

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
3 participants
@Constellation @webkit-commit-queue @webkit-early-warning-system