Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ObjC class name of decode failures in crash logs' register values #17194

Conversation

achristensen07
Copy link
Contributor

@achristensen07 achristensen07 commented Aug 29, 2023

df817db

Include ObjC class name of decode failures in crash logs' register values
https://bugs.webkit.org/show_bug.cgi?id=260871
rdar://114119254

Reviewed by David Kilzer.

Logs in rdar://113527046 indicate something occasionally crashes here, but we don't know what.
This will help gather information about what occasionally crashes.

* Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(checkIfClassIsAllowed):

Canonical link: https://commits.webkit.org/267425@main

559531b

Misc iOS, tvOS & watchOS macOS Linux Windows
  πŸ§ͺ style   πŸ›  ios   πŸ›  mac   πŸ›  wpe   πŸ›  wincairo
  πŸ›  ios-sim   πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
  πŸ§ͺ webkitperl   πŸ§ͺ ios-wk2   πŸ§ͺ api-mac   πŸ›  gtk
  πŸ§ͺ ios-wk2-wpt   πŸ§ͺ mac-wk1   πŸ§ͺ gtk-wk2
  πŸ§ͺ api-ios   πŸ§ͺ mac-wk2   πŸ§ͺ api-gtk
  πŸ›  tv   πŸ§ͺ mac-AS-debug-wk2
  πŸ›  tv-sim   πŸ§ͺ mac-wk2-stress
  πŸ›  watch
  πŸ›  watch-sim

@achristensen07 achristensen07 self-assigned this Aug 29, 2023
@achristensen07 achristensen07 added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Aug 29, 2023
@achristensen07 achristensen07 force-pushed the eng/Include-ObjC-class-name-of-decode-failures-in-crash-logs-register-values branch from 559531b to 0e8ea00 Compare August 29, 2023 20:04
Copy link
Contributor

@ddkilzer ddkilzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@achristensen07 achristensen07 added merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merge-queue Applied to send a pull request to merge-queue labels Aug 29, 2023
…lues

https://bugs.webkit.org/show_bug.cgi?id=260871
rdar://114119254

Reviewed by David Kilzer.

Logs in rdar://113527046 indicate something occasionally crashes here, but we don't know what.
This will help gather information about what occasionally crashes.

* Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(checkIfClassIsAllowed):

Canonical link: https://commits.webkit.org/267425@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Include-ObjC-class-name-of-decode-failures-in-crash-logs-register-values branch from 0e8ea00 to df817db Compare August 29, 2023 21:49
@webkit-commit-queue
Copy link
Collaborator

Committed 267425@main (df817db): https://commits.webkit.org/267425@main

Reviewed commits have been landed. Closing PR #17194 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit df817db into WebKit:main Aug 29, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
4 participants