Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move off of UIKit SPI: -[UIContextMenuInteraction gestureRecognizerForFailureRelationships] #17211

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Move off of UIKit SPI: -[UIContextMenuInteraction gestureRecognizerForFailureRelationships] #17211

merged 1 commit into from
Aug 30, 2023

Conversation

whsieh
Copy link
Member

@whsieh whsieh commented Aug 30, 2023 •
edited by webkit-early-warning-system
Loading

a183125

Move off of UIKit SPI: -[UIContextMenuInteraction gestureRecognizerForFailureRelationships]
https://bugs.webkit.org/show_bug.cgi?id=260887
rdar://114330991

Reviewed by Tim Horton.

Use a combination of `-name` and `-view` to identify gestures used to add failure requirements for
context menu interactions on `WKContentView`.

* Source/WebKit/Platform/spi/ios/UIKitSPI.h:

Remove the now-unused declaration.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _isContextMenuGestureRecognizerForFailureRelationships:]):
(-[WKContentView gestureRecognizer:shouldRequireFailureOfGestureRecognizer:]):
(-[WKContentView gestureRecognizer:shouldBeRequiredToFailByGestureRecognizer:]):
(-[WKContentView deferringGestureRecognizer:shouldDeferOtherGestureRecognizer:]):

Canonical link: https://commits.webkit.org/267444@main

8da2a96

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@whsieh whsieh requested a review from cdumez as a code owner August 30, 2023 01:15
@whsieh whsieh self-assigned this Aug 30, 2023
@whsieh whsieh added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Aug 30, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 30, 2023 •
edited
Loading

EWS run on current version of this PR (hash 8da2a96)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

hortont424
hortont424 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@hortont424 hortont424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadcat

@whsieh
Copy link
Member Author

whsieh commented Aug 30, 2023 •
edited
Loading

Sadcat

🥲

(Thanks for the review)

@whsieh whsieh added the merge-queue Applied to send a pull request to merge-queue label Aug 30, 2023
@whsieh
Move off of UIKit SPI: -[UIContextMenuInteraction gestureRecognizerFo…
a183125 
…rFailureRelationships]

https://bugs.webkit.org/show_bug.cgi?id=260887
rdar://114330991

Reviewed by Tim Horton.

Use a combination of `-name` and `-view` to identify gestures used to add failure requirements for
context menu interactions on `WKContentView`.

* Source/WebKit/Platform/spi/ios/UIKitSPI.h:

Remove the now-unused declaration.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _isContextMenuGestureRecognizerForFailureRelationships:]):
(-[WKContentView gestureRecognizer:shouldRequireFailureOfGestureRecognizer:]):
(-[WKContentView gestureRecognizer:shouldBeRequiredToFailByGestureRecognizer:]):
(-[WKContentView deferringGestureRecognizer:shouldDeferOtherGestureRecognizer:]):

Canonical link: https://commits.webkit.org/267444@main
@webkit-commit-queue
Copy link
Collaborator

Committed 267444@main (a183125): https://commits.webkit.org/267444@main

Reviewed commits have been landed. Closing PR #17211 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit a183125 into WebKit:main Aug 30, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 30, 2023
@whsieh whsieh deleted the eng/260887 branch August 30, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hortont424 hortont424 hortont424 approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@pxlcoder pxlcoder Awaiting requested review from pxlcoder

@megangardner megangardner Awaiting requested review from megangardner

Assignees

@whsieh whsieh

Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
Milestone
No milestone
4 participants
@whsieh @webkit-early-warning-system @webkit-commit-queue @hortont424