Allow hex() to be used with LOG_WITH_STREAM() #17269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litherum
added
the
Text
|
EWS run on current version of this PR (hash b9a5367) |
smfr
approved these changes
Aug 31, 2023
https://bugs.webkit.org/show_bug.cgi?id=260945 rdar://114742843 Reviewed by Simon Fraser. TextStream just needs to be able to use the return type of hex(). * Source/WTF/wtf/text/TextStream.cpp: (WTF::TextStream::operator<<): * Source/WTF/wtf/text/TextStream.h: * Tools/TestWebKitAPI/Tests/WTF/cocoa/TextStreamCocoa.cpp: (TEST): Canonical link: https://commits.webkit.org/267490@main
webkit-commit-queue
force-pushed
the
eng/Allow-hex-to-be-used-with-LOG_WITH_STREAM
branch
from
b9a5367
to
a65bf78
Compare
|
Committed 267490@main (a65bf78): https://commits.webkit.org/267490@main Reviewed commits have been landed. Closing PR #17269 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
|
Oh no I got confused and accidentally landed it too early :( |
|
Landing in #17283 |
webkit-commit-queue
pushed a commit
to litherum/WebKit
that referenced
this pull request
Aug 31, 2023
https://bugs.webkit.org/show_bug.cgi?id=260956 rdar://114751994 Reviewed by Simon Fraser. Addressing review feedback from WebKit#17269 (review) * Source/WTF/wtf/text/TextStream.cpp: (WTF::TextStream::operator<<): * Source/WTF/wtf/text/TextStream.h: * Tools/TestWebKitAPI/Tests/WTF/cocoa/TextStreamCocoa.cpp: (TEST): Canonical link: https://commits.webkit.org/267493@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a65bf78
b9a5367
🧪 wpe-wk2🧪 gtk-wk2🧪 api-gtk🧪 jsc-armv7-tests