Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy more smart pointers in Source/WebKit/UIProcess/Notifications and Source/WebKit/UIProcess/PDF #17278

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Deploy more smart pointers in Source/WebKit/UIProcess/Notifications and Source/WebKit/UIProcess/PDF #17278

merged 1 commit into from
Aug 31, 2023

Conversation

rniwa
Copy link
Member

@rniwa rniwa commented Aug 31, 2023 •
edited by webkit-early-warning-system
Loading

dc32864

Deploy more smart pointers in Source/WebKit/UIProcess/Notifications and Source/WebKit/UIProcess/PDF
https://bugs.webkit.org/show_bug.cgi?id=260952

Reviewed by Chris Dumez.

Deployed more smart pointers as found by clang static analyzer.

* Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::sharedServiceWorkerManager):
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications):
* Source/WebKit/UIProcess/Notifications/WebNotificationProvider.cpp:
(WebKit::WebNotificationProvider::notificationPermissions):
* Source/WebKit/UIProcess/PDF/WKPDFHUDView.mm:
(-[WKPDFHUDView hitTest:]):
(-[WKPDFHUDView _performActionForControl:]):

Canonical link: https://commits.webkit.org/267528@main

99b132a

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@rniwa rniwa requested a review from cdumez as a code owner August 31, 2023 07:39
@rniwa rniwa self-assigned this Aug 31, 2023
@rniwa rniwa added the WebKit2 Bugs relating to the WebKit2 API layer label Aug 31, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 31, 2023 •
edited
Loading

EWS run on current version of this PR (hash 99b132a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 31, 2023
@rniwa
Deploy more smart pointers in Source/WebKit/UIProcess/Notifications a…
dc32864 
…nd Source/WebKit/UIProcess/PDF

https://bugs.webkit.org/show_bug.cgi?id=260952

Reviewed by Chris Dumez.

Deployed more smart pointers as found by clang static analyzer.

* Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::sharedServiceWorkerManager):
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications):
* Source/WebKit/UIProcess/Notifications/WebNotificationProvider.cpp:
(WebKit::WebNotificationProvider::notificationPermissions):
* Source/WebKit/UIProcess/PDF/WKPDFHUDView.mm:
(-[WKPDFHUDView hitTest:]):
(-[WKPDFHUDView _performActionForControl:]):

Canonical link: https://commits.webkit.org/267528@main
@webkit-commit-queue
Copy link
Collaborator

Committed 267528@main (dc32864): https://commits.webkit.org/267528@main

Reviewed commits have been landed. Closing PR #17278 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit dc32864 into WebKit:main Aug 31, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 31, 2023
@rniwa rniwa deleted the fix260952 branch August 31, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

Assignees

@rniwa rniwa

Labels
WebKit2 Bugs relating to the WebKit2 API layer
Projects
None yet
Milestone
No milestone
4 participants
@rniwa @webkit-early-warning-system @webkit-commit-queue @cdumez