Fix PushManager in ephemeral sessions #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnham
added
WebKit Misc.
webkit-early-warning-system
added
the
merging-blocked
bnham
force-pushed
the
eng/pushmanager-ephemeral
branch
from
c1d1be7
to
ed3444d
Compare
webkit-early-warning-system
added
the
merging-blocked
bnham
force-pushed
the
eng/pushmanager-ephemeral
branch
2 times, most recently
from
6cc8e54
to
c23a0eb
Compare
https://bugs.webkit.org/show_bug.cgi?id=241934 Reviewed by Geoffrey Garen. PushManager does not behave correctly when invoked in an ephemeral session. For instance: - PushManager.subscribe and PushManager.getSubscription fail with an AbortError. - PushManager.permissionState returns the persistent session's notification permissions for the given origin. This patch makes PushManager in ephemeral sessions behave as if a user denied notification permissions for all origins (which users can already do in persistent sessions via the appropriate checkbox). This also prevents these APIs from being used to detect private browsing mode. * LayoutTests/http/tests/push-api/permissions-ephemeral-expected.txt: Added. * LayoutTests/http/tests/push-api/permissions-ephemeral.html: Added. * LayoutTests/http/tests/push-api/resources/subscribe-tests.js * LayoutTests/http/tests/push-api/resources/subscribe-worker.js * LayoutTests/platform/gtk/TestExpectations: * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac-wk1/TestExpectations: * LayoutTests/platform/win/TestExpectations: * Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.cpp: (WebKit::NetworkNotificationManager::getPushSubscription): (WebKit::NetworkNotificationManager::getPushPermissionState): * Source/WebKit/WebProcess/WebCoreSupport/WebNotificationClient.cpp: (WebKit::WebNotificationClient::requestPermission): (WebKit::WebNotificationClient::checkPermission): Canonical link: https://commits.webkit.org/251831@main
webkit-early-warning-system
force-pushed
the
eng/pushmanager-ephemeral
branch
from
c23a0eb
to
0570dfb
Compare
|
Committed 251831@main (0570dfb): https://commits.webkit.org/251831@main Reviewed commits have been landed. Closing PR #1744 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0570dfb