New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TextureMapper] Use linear sampling when blurring for better performance #17471
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
Aki-7:eng/TextureMapper-Use-linear-sampling-when-blurring-for-better-performance
Sep 7, 2023
Merged
[TextureMapper] Use linear sampling when blurring for better performance #17471
webkit-commit-queue
merged 1 commit into
WebKit:main
from
Aki-7:eng/TextureMapper-Use-linear-sampling-when-blurring-for-better-performance
Sep 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash c25145b) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Sep 6, 2023
Aki-7
force-pushed
the
eng/TextureMapper-Use-linear-sampling-when-blurring-for-better-performance
branch
from
September 7, 2023 01:37
c25145b
to
76f7aff
Compare
EWS run on current version of this PR (hash 76f7aff) |
fujii
approved these changes
Sep 7, 2023
fujii
added
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
and removed
merging-blocked
Applied to prevent a change from being merged
labels
Sep 7, 2023
https://bugs.webkit.org/show_bug.cgi?id=261102 Reviewed by Fujii Hironori. To reduce the GPU load for gaussian blur, this fix reduces the size of kernel use for the blur. By adjusting the position(offset) to sample the texture and the weight of each element of the kernel so that the linear interpolation during texture sampling samples two texels and properly weights them, we can reduce the size of the kernel without changing behaviour. * Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp: (WebCore::kernelHalfSizeToSimplifiedKernelHalfSize): (WebCore::computeGaussianKernel): (WebCore::TextureMapperGL::drawBlurred): * Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp: * Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.h: Canonical link: https://commits.webkit.org/267715@main
webkit-commit-queue
force-pushed
the
eng/TextureMapper-Use-linear-sampling-when-blurring-for-better-performance
branch
from
September 7, 2023 03:28
76f7aff
to
437b554
Compare
Committed 267715@main (437b554): https://commits.webkit.org/267715@main Reviewed commits have been landed. Closing PR #17471 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
437b554
76f7aff
π§ͺ wpe-wk2π§ͺ api-macπ§ͺ gtk-wk2π§ͺ mac-AS-debug-wk2π watch