Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unnecessary operator!=() in WebKit #17528

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Sep 7, 2023

e403bc5

Drop unnecessary operator!=() in WebKit
https://bugs.webkit.org/show_bug.cgi?id=261253

Reviewed by Michael Catanzaro.

Drop unnecessary operator!=() in WebKit and let the compiler generate them now
that we support C++20.

* Source/JavaScriptCore/wasm/generateWasmOpsHeader.py:
* Source/WebCore/platform/audio/gstreamer/GStreamerAudioStreamDescription.h:
* Source/WebCore/platform/graphics/freetype/FontSetCache.h:
(WebCore::FontSetCacheKey::operator!= const): Deleted.
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:
(GstIteratorAdaptor::iterator::operator== const):
(GstIteratorAdaptor::iterator::operator!= const): Deleted.
* Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.h:
(WebCore::GStreamerRegistryScanner::RegistryLookupResult::operator==):
(WebCore::GStreamerRegistryScanner::RegistryLookupResult::operator!=): Deleted.
* Source/WebCore/platform/graphics/win/ComplexTextControllerUniscribe.cpp:
(WebCore::BidiRange::Iterator::operator==):
(WebCore::BidiRange::Iterator::operator!=): Deleted.
* Source/WebCore/platform/network/curl/CertificateInfo.h:
(WebCore::CertificateInfo::operator== const): Deleted.
(WebCore::CertificateInfo::operator!= const): Deleted.
* Source/WebCore/platform/network/soup/CertificateInfo.h:
(WebCore::CertificateInfo::operator== const):
(WebCore::CertificateInfo::operator!= const): Deleted.

Canonical link: https://commits.webkit.org/267735@main

775e2e8

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  πŸ§ͺ jsc βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ jsc-arm64 βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ›  jsc-armv7
βœ… πŸ›  tv-sim βœ… πŸ§ͺ jsc-armv7-tests
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch βœ… πŸ›  jsc-mips
βœ… πŸ›  watch-sim βœ… πŸ§ͺ jsc-mips-tests

@cdumez cdumez self-assigned this Sep 7, 2023
@cdumez cdumez added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Sep 7, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 7, 2023
@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label Sep 7, 2023
@cdumez cdumez marked this pull request as ready for review September 7, 2023 14:49
@cdumez cdumez requested review from a team and philn as code owners September 7, 2023 14:49
@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Sep 7, 2023
https://bugs.webkit.org/show_bug.cgi?id=261253

Reviewed by Michael Catanzaro.

Drop unnecessary operator!=() in WebKit and let the compiler generate them now
that we support C++20.

* Source/JavaScriptCore/wasm/generateWasmOpsHeader.py:
* Source/WebCore/platform/audio/gstreamer/GStreamerAudioStreamDescription.h:
* Source/WebCore/platform/graphics/freetype/FontSetCache.h:
(WebCore::FontSetCacheKey::operator!= const): Deleted.
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:
(GstIteratorAdaptor::iterator::operator== const):
(GstIteratorAdaptor::iterator::operator!= const): Deleted.
* Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.h:
(WebCore::GStreamerRegistryScanner::RegistryLookupResult::operator==):
(WebCore::GStreamerRegistryScanner::RegistryLookupResult::operator!=): Deleted.
* Source/WebCore/platform/graphics/win/ComplexTextControllerUniscribe.cpp:
(WebCore::BidiRange::Iterator::operator==):
(WebCore::BidiRange::Iterator::operator!=): Deleted.
* Source/WebCore/platform/network/curl/CertificateInfo.h:
(WebCore::CertificateInfo::operator== const): Deleted.
(WebCore::CertificateInfo::operator!= const): Deleted.
* Source/WebCore/platform/network/soup/CertificateInfo.h:
(WebCore::CertificateInfo::operator== const):
(WebCore::CertificateInfo::operator!= const): Deleted.

Canonical link: https://commits.webkit.org/267735@main
@webkit-commit-queue
Copy link
Collaborator

Committed 267735@main (e403bc5): https://commits.webkit.org/267735@main

Reviewed commits have been landed. Closing PR #17528 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit e403bc5 into WebKit:main Sep 7, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
5 participants